Only send relevant completion resolve parameters#45068
Merged
dibarbet merged 2 commits intodotnet:masterfrom Jun 15, 2020
Merged
Only send relevant completion resolve parameters#45068dibarbet merged 2 commits intodotnet:masterfrom
dibarbet merged 2 commits intodotnet:masterfrom
Conversation
ryzngard
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1117748
We don't need to send the IProgress (or the rest of the parameters) on the completion resolve request.
The LSP client also fixed de-serialization of related parameters with a custom deserializer.