Mount credentials secret to reverse proxy#473
Merged
Conversation
Powermax driver and reverseproxy changes for mounted secret
Changes to reverse proxy to use mounted cm for params
* testing * Update go modules * Fix config map processing * Fix config unit tests * Update go.mod * Fix proxy unit tests
donatwork
reviewed
Mar 2, 2025
donatwork
reviewed
Mar 2, 2025
donatwork
reviewed
Mar 2, 2025
falfaroc
reviewed
Mar 4, 2025
falfaroc
previously approved these changes
Mar 4, 2025
xuluna
previously approved these changes
Mar 4, 2025
bharathsreekanth
previously approved these changes
Mar 4, 2025
tdawe
reviewed
Mar 4, 2025
To ensure backwards compatibility, the inCluster variable will be defaulted to true. All charts already set this to true so functionality will stay consistent
tdawe
previously approved these changes
Mar 4, 2025
falfaroc
previously approved these changes
Mar 4, 2025
- removing old linting/vetting targets and shell scripts that use outdated static checkers. defer to GH actions
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
falfaroc
approved these changes
Mar 5, 2025
bharathsreekanth
approved these changes
Mar 5, 2025
tdawe
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The csi-reverseproxy accesses Unisphere credentials by using a K8s API call to read them from a configmap, unlike all the other drivers, which mount a secret as a volume in the driver pod.
This feature brings the reverseproxy in line with all the other drivers – the configmap will be converted to a secret and mounted to the controller pod as a volume.
The ConfigMap functionality has been deprecated but currently remains intact for backward compatibility until it is removed in a later release.
GitHub Issues
Checklist:
How Has This Been Tested?
cert-csi suites for both mount credentials and configmap config methods