Usr/sreekb/mount creds port#418
Merged
bharathsreekanth merged 18 commits intoJan 27, 2025
Merged
Conversation
kumarp20
reviewed
Jan 23, 2025
2 tasks
tdawe
reviewed
Jan 23, 2025
harshitap26
reviewed
Jan 25, 2025
tdawe
reviewed
Jan 27, 2025
tdawe
reviewed
Jan 27, 2025
tdawe
approved these changes
Jan 27, 2025
Contributor
|
Approving. Checks are failing but this is going into a feature branch. Unit test coverage will need to be updated prior to merging to main. |
harshitap26
approved these changes
Jan 27, 2025
Contributor
Author
That is correct. UTs are being worked on will be addressed before merge to main. These changes are to facilitate having a working solution in a feature branch for parallel development. |
2 tasks
lukeatdell
pushed a commit
that referenced
this pull request
Feb 28, 2025
Powermax driver and reverseproxy changes for mounted secret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes to powermax driver and reverseproxy to read from mounted secret.
DISCLAIMER:
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Manual testing only thus far, with mounted secret as well as regression testing with existing config map approach.
Tested with multiple arrays and unisphere endpoints.
Tested with updating the secrets and configmap on the fly to validate the watcher.