Improve code coverage for config.go#477
Merged
lukeatdell merged 6 commits intoMar 3, 2025
Merged
Conversation
- created an interface for viper actions so we dont have to create temp files for tests.
xuluna
approved these changes
Mar 3, 2025
falfaroc
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding some tests to improve coverage for csireverseproxy's
config.go.Created a config manager interface that is satisfied by
viper.Viperand allows us to mock responses from viper without the need to create temporary configmaps and secrets on the file system.GitHub Issues
Checklist:
How Has This Been Tested?
GH Actions unit tests