Skip to content

Changes to revproxy to use mounted cm for params#424

Merged
bharathsreekanth merged 3 commits into
usr/spark/mount-credentialsfrom
usr/sreekb/reverseproxy-configmap-update
Jan 28, 2025
Merged

Changes to revproxy to use mounted cm for params#424
bharathsreekanth merged 3 commits into
usr/spark/mount-credentialsfrom
usr/sreekb/reverseproxy-configmap-update

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Description

  1. Update reversepoxy to use powermax-config-params to infer port, log level etc.
  2. Simplified the watcher logic to use parameterized viper instances as opposed to global instances.
  3. Reverted back to throwing/return error when PrimaryEndpoint of a storage array does not have mapping entry under management servers.
  4. Fixed prior review comments.

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| (https://github.com/dell/csm/issues/1614)|

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Manually tested mounted, secret and configmap cases with multiple arrays. Tested watcher logic by modifying params on the fly after the proxy is up and running.

@falfaroc

Copy link
Copy Markdown
Contributor

suggestion: Please add a Github issue to the PR.

Comment thread csireverseproxy/main.go
Comment thread csireverseproxy/pkg/config/config.go
@bharathsreekanth

Copy link
Copy Markdown
Contributor Author

suggestion: Please add a Github issue to the PR.

Done

@bharathsreekanth bharathsreekanth merged commit dcaab0c into usr/spark/mount-credentials Jan 28, 2025
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/reverseproxy-configmap-update branch January 28, 2025 16:08
lukeatdell pushed a commit that referenced this pull request Feb 28, 2025
Changes to reverse proxy to use mounted cm for params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants