Updated unit tests, other minor changes#479
Merged
bharathsreekanth merged 2 commits intoMar 4, 2025
Merged
Conversation
bharathsreekanth
commented
Mar 4, 2025
| } | ||
| found = conf.IsSecretConfiguredForArrays(secret.Name) | ||
| if found { | ||
| if getEnv(common.EnvReverseProxyUseSecret, "false") == "true" { |
Contributor
Author
There was a problem hiding this comment.
This code not needed as we never invoke the event handler for mounted secret. Mounted secrets are only monitored via viper and not directly as K8S entities.
lukeatdell
approved these changes
Mar 4, 2025
lukeatdell
approved these changes
Mar 4, 2025
tdawe
approved these changes
Mar 4, 2025
harshitap26
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated unit tests for reverseproxy main pkg.
Updated main.go for removing unncessary code checks for secret.
Updated mock to include a new function for updating secret.
Refactored unit tests to follow best practices, added more functionality.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Unit test run several time to ensure success.
Created new image, deployed on K8S cluster and verified reverseproxy starts ok.