Skip to content

Update ReverseProxy Modules#441

Merged
falfaroc merged 6 commits into
usr/spark/mount-credentialsfrom
usr/falfaroc/update-reverse-proxy-modules
Feb 4, 2025
Merged

Update ReverseProxy Modules#441
falfaroc merged 6 commits into
usr/spark/mount-credentialsfrom
usr/falfaroc/update-reverse-proxy-modules

Conversation

@falfaroc

@falfaroc falfaroc commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Description

Update all go modules to the latest version. Prior to this, the viper decoding was being handled in an outdated way. This PR fixes that and makes it generate across modules that depend on the config decoding.

With this version of viper, when it reads in the config, every key is converted to lowercase and string for simple parsing. Otherwise, if we try to convert to interface{}, a conversion error is given.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1614

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Update and manually ensure/test that the correct modules are being used.

Comment thread csireverseproxy/go.mod Outdated
@falfaroc falfaroc requested a review from lukeatdell February 3, 2025 21:43
@falfaroc falfaroc merged commit 32e4336 into usr/spark/mount-credentials Feb 4, 2025
@falfaroc falfaroc deleted the usr/falfaroc/update-reverse-proxy-modules branch February 4, 2025 13:39
lukeatdell pushed a commit that referenced this pull request Feb 28, 2025
* testing

* Update go modules

* Fix config map processing

* Fix config unit tests

* Update go.mod

* Fix proxy unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants