Skip to content

Update unit test coverage across all packages#466

Merged
lukeatdell merged 36 commits into
mainfrom
usr/spark/unit-test-improvements
Feb 28, 2025
Merged

Update unit test coverage across all packages#466
lukeatdell merged 36 commits into
mainfrom
usr/spark/unit-test-improvements

Conversation

@tdawe

@tdawe tdawe commented Feb 25, 2025 •
edited by harshitap26
Loading

Copy link
Copy Markdown
Contributor

Description

Update unit test coverage across all packages. All packages are finally over the 85% threshold.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ensured that all existing and new unit tests and PR checks are passing.
  • The Cert-CSI test suites run successfully for the images build with the above changes
    CertCSI_Tests.log

Note: The Snap suite, Replication suite and the Capacity Tracking Suite are failing which are failing against the nightly images as well and has not been introduced with these changes.
The defect https://jira.cec.lab.emc.com/browse/KRV-28221 has already been created for this previously. PR for the defect - #347 for which the solution has not been tested against Cert-CSI.

tdawe and others added 24 commits January 30, 2025 09:35
@tdawe
Update unit tests for provider package (#432)
0802e1c
@tdawe
Updated unit tests for symmetrix (#429)
d5ebc05
@tdawe
Added tests for migration package (#439)
9e46493
@tdawe
Updated unit tests for semver package (#442)
62c17f7
@bharathsreekanth
Updated/Added UT for several packages under reverseproxy/pkg
691c6af 
Updated/Added UT for several packages under reverseproxy/pkg
@lukeatdell
Add unit tests to k8sutils package (#446)
f3c0e49
@lukeatdell
Refactor main and add unit tests (#447)
e7a0ef3 
* refactor main and add unit tests
@tdawe
Added unit tests for file package (#450)
a645171
@bharathsreekanth
UT for k8sutils package
5a0a04e
@falfaroc
Add Proxy Package Tests for ReverseProxy (#452)
1a21cfe
@bharathsreekanth
csireverseproxy - improve unit test coverage for main and pkg/config (#…
480aa5f 
…451)
@bharathsreekanth
Update config.yaml for config tests (#454)
9895461
@lukeatdell
Fix data races in reverse proxy unit tests (#458)
55ebc32
@falfaroc @lukeatdell
@tdawe @kumarp20 @xuluna @harshitap26 @bharathsreekanth
Increase Unit Test Coverage (#456)
68dcc8a 
Co-authored-by: Lau, Luke <luke.lau1@dell.com>
Co-authored-by: Trevor Dawe <trevor.dawe@dell.com>
Co-authored-by: Pooja Kumar <pooja.prasannakumar@dell.com>
Co-authored-by: Luna Xu <ms.luna.xu@gmail.com>
Co-authored-by: Harshita Pandey <Harshita_Pandey@dell.com>
Co-authored-by: Bharath Sreekanth <bharath.sreekanth@emc.com>
Co-authored-by: lukeatdell <115811384+lukeatdell@users.noreply.github.com>
@lukeatdell
resolve gosec int overflow in metro.go
cd49499
@lukeatdell
fixing linter errors
5cdeeac
@xuluna
add GetVSphereFCHostSGAndMVIDFromNodeID test
f3d7aa3
@falfaroc
Add partial increases to vsphere unit tests (#461)
a509390
@lukeatdell
make mutex in struct a pointer
14dba7c
@lukeatdell
add tests for verifyPGID and ctrlPublishVol
3b0f082
@tdawe
Update coverage for deletion_worker and replication (#464)
ecb52de
@lukeatdell
update gopowermax and golang version
ac3f962
@lukeatdell
revert golang version for now
57cdf70
@falfaroc @lukeatdell
Various Unit Test Improvements (#463)
5a7f2b6 
Co-authored-by: lukeatdell <115811384+lukeatdell@users.noreply.github.com>
tdawe
tdawe commented Feb 26, 2025
View reviewed changes
Comment thread service/node_test.go
tdawe
tdawe commented Feb 26, 2025
View reviewed changes
Comment thread service/node_test.go Outdated
donatwork
donatwork reviewed Feb 27, 2025
View reviewed changes
Comment thread csireverseproxy/Makefile
donatwork
donatwork previously approved these changes Feb 27, 2025
View reviewed changes
donatwork
donatwork reviewed Feb 27, 2025
View reviewed changes
Comment thread service/vsphere.go
lukeatdell
lukeatdell reviewed Feb 27, 2025
View reviewed changes
Comment thread csireverseproxy/pkg/proxy/proxy.go
lukeatdell
lukeatdell reviewed Feb 27, 2025
View reviewed changes
Comment thread service/node_connectivity_checker.go Outdated
falfaroc
falfaroc previously approved these changes Feb 27, 2025
View reviewed changes
Comment thread csireverseproxy/pkg/config/config.go Outdated
Comment thread service/Makefile
Comment thread service/features/node_publish_unpublish.feature
Comment thread service/migration_test.go
lukeatdell
lukeatdell reviewed Feb 27, 2025
View reviewed changes
Comment thread service/node_connectivity_checker.go Outdated
alikdell
alikdell previously approved these changes Feb 27, 2025
View reviewed changes
@bharathsreekanth bharathsreekanth dismissed stale reviews from alikdell and falfaroc via e9d90b9 February 27, 2025 19:37
donatwork
donatwork approved these changes Feb 28, 2025
View reviewed changes

@donatwork donatwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeatdell lukeatdell merged commit a41d7c8 into main Feb 28, 2025
@lukeatdell lukeatdell deleted the usr/spark/unit-test-improvements branch February 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

+4 more reviewers

@falfaroc falfaroc falfaroc left review comments

@bharathsreekanth bharathsreekanth bharathsreekanth left review comments

@lukeatdell lukeatdell lukeatdell left review comments

@donatwork donatwork donatwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tdawe @falfaroc @donatwork @alikdell @bharathsreekanth @lukeatdell @xuluna @harshitap26