Skip to content

Updated unit tests for symmetrix#429

Merged
tdawe merged 6 commits into
usr/spark/unit-test-improvementsfrom
usr/tdawe/symmetrix-unit-tests
Jan 30, 2025
Merged

Updated unit tests for symmetrix#429
tdawe merged 6 commits into
usr/spark/unit-test-improvementsfrom
usr/tdawe/symmetrix-unit-tests

Conversation

@tdawe

@tdawe tdawe commented Jan 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

PR targets the usr/spark/unit-test-improvements branch.

Increases code coverage for the symmetrix package to 92.3%

# go test -cover -race -count 1 ./...
        github.com/dell/csi-powermax/v2/pkg/symmetrix/mocks             coverage: 0.0% of statements
ok      github.com/dell/csi-powermax/v2/pkg/symmetrix   1.051s  coverage: 92.3% of statements

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Unit tests were successfully run for this package.

@tdawe tdawe merged commit d5ebc05 into usr/spark/unit-test-improvements Jan 30, 2025
@tdawe tdawe deleted the usr/tdawe/symmetrix-unit-tests branch January 30, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@donatwork donatwork Awaiting requested review from donatwork

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

1 more reviewer

@lukeatdell lukeatdell lukeatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdawe @lukeatdell