Skip to content

Refactor main and add unit tests#447

Merged
lukeatdell merged 2 commits into
usr/spark/unit-test-improvementsfrom
usr/lukeatdell/ut-main
Feb 6, 2025
Merged

Refactor main and add unit tests#447
lukeatdell merged 2 commits into
usr/spark/unit-test-improvementsfrom
usr/lukeatdell/ut-main

Conversation

@lukeatdell

Copy link
Copy Markdown
Contributor

Description

Adding unit tests to main to bring coverage for main.go to 93%+.
Refactored main to accommodate dependency injection for testing.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Built a new image for the driver, deployed and tested via cert-csi certify with both a single controller and multiple controller replicas.

@jooseppi-luna jooseppi-luna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks Luke!

@lukeatdell lukeatdell merged commit e7a0ef3 into usr/spark/unit-test-improvements Feb 6, 2025
@lukeatdell lukeatdell deleted the usr/lukeatdell/ut-main branch February 6, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants