Refactor main and add unit tests#447
Merged
lukeatdell merged 2 commits intoFeb 6, 2025
Merged
Conversation
tdawe
approved these changes
Feb 6, 2025
jooseppi-luna
approved these changes
Feb 6, 2025
jooseppi-luna
left a comment
Contributor
There was a problem hiding this comment.
This looks great thanks Luke!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding unit tests to main to bring coverage for
main.goto 93%+.Refactored main to accommodate dependency injection for testing.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Built a new image for the driver, deployed and tested via
cert-csi certifywith both a single controller and multiple controller replicas.