Skip to content

Increase Unit Test Coverage#456

Merged
falfaroc merged 40 commits into
usr/spark/unit-test-improvementsfrom
usr/spark/ut-svc-pkg
Feb 24, 2025
Merged

Increase Unit Test Coverage#456
falfaroc merged 40 commits into
usr/spark/unit-test-improvementsfrom
usr/spark/ut-svc-pkg

Conversation

@falfaroc

@falfaroc falfaroc commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Further increase unit test coverage in most of the packages, mostly focused around the service package. Also, resolve many of the DATA RACE found throughout the unit tests.

Note: Outstanding the remainder of the service package. Also, other branches will be used for the rest of the package.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ensured that unit tests improvements are being run.
2025-02-24T18:06:37.3439684Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/file is 97.9%, not lower than 90%
2025-02-24T18:06:37.3447668Z PASS: coverage for package revproxy/v2/pkg/cache is 100.0%, not lower than 90%
2025-02-24T18:06:37.3456738Z PASS: coverage for package revproxy/v2/pkg/config is 90.9%, not lower than 90%
2025-02-24T18:06:37.3464644Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/symmetrix is 90.2%, not lower than 90%
2025-02-24T18:06:37.3472396Z PASS: coverage for package revproxy/v2/pkg/common is 92.0%, not lower than 90%
2025-02-24T18:06:37.3480447Z PASS: coverage for package github.com/dell/csi-powermax/v2 is 93.1%, not lower than 90%
2025-02-24T18:06:37.3488472Z PASS: coverage for package github.com/dell/csi-powermax/v2/k8sutils is 94.9%, not lower than 90%
2025-02-24T18:06:37.3496332Z PASS: coverage for package revproxy/v2/pkg/utils is 90.6%, not lower than 90%
2025-02-24T18:06:37.3504095Z PASS: coverage for package revproxy/v2/pkg/servermock is 100.0%, not lower than 90%
2025-02-24T18:06:37.3512007Z PASS: coverage for package revproxy/v2/pkg/proxy is 91.6%, not lower than 90%
2025-02-24T18:06:37.3519459Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/migration is 90.5%, not lower than 90%
2025-02-24T18:06:37.3526774Z PASS: coverage for package github.com/dell/csi-powermax/v2/provider is 100.0%, not lower than 90%
2025-02-24T18:06:37.3534931Z FAIL: coverage for package github.com/dell/csi-powermax/v2/service is 85.0%, lower than 90%
2025-02-24T18:06:37.3542695Z PASS: coverage for package revproxy/v2/pkg/k8sutils is 91.3%, not lower than 90%
2025-02-24T18:06:37.3549910Z PASS: coverage for package revproxy/v2 is 90.3%, not lower than 90%

lukeatdell and others added 13 commits February 10, 2025 09:54
@lukeatdell
migrate snapCleaner global to svc struct member.
5bbc29a 
- migration mitigates data races found during testing.
@lukeatdell
create admin clients for new service instances
cc031ab
@tdawe
Fix race condition in node_connectivity_checker
f8d37c5
@lukeatdell
use safe error injector func from gopowermax mock pkg
f443e85 
- Setting induced errors directly from test code was causing data races.
@tdawe
Fix race condition in deletion worker
2182099
@lukeatdell
update gopowermax module version.
5853e49 
- use updates to gopowermax client.
@tdawe
Added storeProbeStatus to fix race condition
8927281
@lukeatdell
refactor makefile for easier use.
8977ecf 
- add -race flag to testing targets.
- add clean as a separate target to speed up test execution.
@tdawe
Fix race condition with induced error global variables
4395e8d
@kumarp20
Fix race conditions in metro.go
d190d29
@kumarp20
fix race condition related to nvmeTCPtargets map access
24dcaa7
@lukeatdell
update gopowermax refs and module version
4819f78
@tdawe
Fix race condition when getting powermax client
2f3de9d
@falfaroc falfaroc changed the title Usr/spark/ut svc pkg Increase Unit Test Coverage Feb 13, 2025
@lukeatdell lukeatdell changed the base branch from main to usr/spark/unit-test-improvements February 13, 2025 18:29
lukeatdell and others added 15 commits February 13, 2025 13:38
bharathsreekanth and others added 11 commits February 19, 2025 01:41
@bharathsreekanth
Refactor interfaces unit test
35c9d50
@lukeatdell
update gomock mod provider in other pkgs
fdd4afb
@kumarp20
unit tests for node.go
7c2a5fe
@kumarp20
Merge branch 'usr/spark/ut-svc-pkg' of https://github.com/dell/csi-po…
8c05757 
…wermax into usr/spark/ut-svc-pkg
@tdawe
Add tests for service.go
da73130
@lukeatdell
add tests for createMetroVolume().
fd709d5 
- added funcs to remove pmax client from client cache after a test.
- added func to remove replication capability from the cache after a test.
@lukeatdell
temporarily resolving issues related to caching data.
017adbe 
- controller.go tests for createMetroVolume cached a "replicationCapability" that was causing other snap.go tests to fail.
- implemented an update to make sure that cache is clean.
@lukeatdell
adding more tests to controller.go
34621bf
@harshitap26
Add unit tests for controller.go
8e1fb65
@harshitap26
Resolving unit tests for TestIsNodeNVMe
94b6f62
@lukeatdell
Merge branch 'usr/spark/unit-test-improvements' into usr/spark/ut-svc…
553a1a6 
…-pkg
@falfaroc falfaroc marked this pull request as ready for review February 24, 2025 17:56
@falfaroc falfaroc merged commit 68dcc8a into usr/spark/unit-test-improvements Feb 24, 2025
@falfaroc falfaroc deleted the usr/spark/ut-svc-pkg branch February 24, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@donatwork donatwork Awaiting requested review from donatwork

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@tdawe tdawe Awaiting requested review from tdawe

2 more reviewers

@xuluna xuluna xuluna approved these changes

@lukeatdell lukeatdell lukeatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@falfaroc @xuluna @lukeatdell @tdawe @kumarp20 @harshitap26 @bharathsreekanth