Skip to content

Add partial increases to vsphere unit tests#461

Merged
falfaroc merged 7 commits into
usr/spark/unit-test-improvementsfrom
usr/falfaroc/vsphere_ut
Feb 25, 2025
Merged

Add partial increases to vsphere unit tests#461
falfaroc merged 7 commits into
usr/spark/unit-test-improvementsfrom
usr/falfaroc/vsphere_ut

Conversation

@falfaroc

@falfaroc falfaroc commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Description

Slightly increase coverage for vsphere.go.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Running Total:

2025-02-24T18:01:00.6923301Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/file is 97.9%, not lower than 90%
2025-02-24T18:01:00.6927896Z PASS: coverage for package revproxy/v2/pkg/cache is 100.0%, not lower than 90%
2025-02-24T18:01:00.6936057Z PASS: coverage for package revproxy/v2/pkg/config is 90.9%, not lower than 90%
2025-02-24T18:01:00.6944099Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/symmetrix is 90.2%, not lower than 90%
2025-02-24T18:01:00.6951942Z PASS: coverage for package revproxy/v2/pkg/common is 92.0%, not lower than 90%
2025-02-24T18:01:00.6959854Z PASS: coverage for package github.com/dell/csi-powermax/v2 is 93.1%, not lower than 90%
2025-02-24T18:01:00.6967665Z PASS: coverage for package github.com/dell/csi-powermax/v2/k8sutils is 94.9%, not lower than 90%
2025-02-24T18:01:00.6975132Z PASS: coverage for package revproxy/v2/pkg/utils is 90.6%, not lower than 90%
2025-02-24T18:01:00.6983136Z PASS: coverage for package revproxy/v2/pkg/servermock is 100.0%, not lower than 90%
2025-02-24T18:01:00.6990802Z PASS: coverage for package revproxy/v2/pkg/proxy is 91.6%, not lower than 90%
2025-02-24T18:01:00.6998800Z PASS: coverage for package github.com/dell/csi-powermax/v2/pkg/migration is 90.5%, not lower than 90%
2025-02-24T18:01:00.7006834Z PASS: coverage for package github.com/dell/csi-powermax/v2/provider is 100.0%, not lower than 90%
2025-02-24T18:01:00.7014738Z FAIL: coverage for package github.com/dell/csi-powermax/v2/service is 85.0%, lower than 90%
2025-02-24T18:01:00.7022287Z PASS: coverage for package revproxy/v2/pkg/k8sutils is 91.3%, not lower than 90%
2025-02-24T18:01:00.7030413Z PASS: coverage for package revproxy/v2 is 90.3%, not lower than 90%

@falfaroc falfaroc force-pushed the usr/falfaroc/vsphere_ut branch from 84f2bb5 to d20e7a6 Compare February 24, 2025 16:47
@falfaroc falfaroc changed the title Usr/falfaroc/vsphere ut Add partial increases to vsphere unit tests Feb 24, 2025
@falfaroc falfaroc force-pushed the usr/falfaroc/vsphere_ut branch from d20e7a6 to 06e3343 Compare February 24, 2025 17:53
Base automatically changed from usr/spark/ut-svc-pkg to usr/spark/unit-test-improvements February 24, 2025 20:04
@falfaroc falfaroc force-pushed the usr/falfaroc/vsphere_ut branch from 06e3343 to ccd536d Compare February 24, 2025 22:26
Comment thread service/vsphere.go
@falfaroc falfaroc merged commit a509390 into usr/spark/unit-test-improvements Feb 25, 2025
@falfaroc falfaroc deleted the usr/falfaroc/vsphere_ut branch February 25, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants