Fix data race in deletion_worker.go#468
Merged
lukeatdell merged 2 commits intoFeb 26, 2025
Merged
Conversation
- running populateDeletionQueue as a goroutine was causing data races with unsafe access to the http client of the powermax client. - instead of running the whole function as a goroutine, only run the queue insertion func as a goroutine.
falfaroc
approved these changes
Feb 26, 2025
xuluna
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring adding volumes to deletion queue
Running
populateDeletionQueue()as a goroutine was causing data races with unsafe concurrent access to the http client of the powermax client while running powermax REST API queries.Instead of running the whole function as a goroutine, only create goroutines for queue insertion operations. Since the queue insertion function needs no reference to the powermax client, there should be no issues.
Also removed a log message in locks.go that printed every 20ms.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration