Add modifyList option to the autocomplete element#9548
Merged
andreslucena merged 3 commits intodecidim:developfrom Jul 13, 2022
Merged
Add modifyList option to the autocomplete element#9548andreslucena merged 3 commits intodecidim:developfrom
modifyList option to the autocomplete element#9548andreslucena merged 3 commits intodecidim:developfrom
Conversation
entantoencuanto
added a commit
that referenced
this pull request
Jul 15, 2022
…ging * feature/redesign-main-footer: Reorder elements in main links of footer and define links and texts Define a cell for static_pages and topics configured to appear in footer Fix translation call Set fixed links in redesigned_main_legal partial Add FooterMenuPresenter to display menu items in footer Fix budgets seeds on non development apps (#9585) Return 404 when there isn't a valid component in program (#9576) Add missing queue close_meeting_reminder to sidekiq configuration (#9568) Make the HERE Map display in the currently selected language (#9552) Add help text for proposals' 'publish answers immediately' setting (#9549) Fix admin language selector with more than 4 locales (#9519) Fix publish event on official proposals (#9421) Prevent missing ActionLog entries to break the application (#9502) Add boilerplate structure to CHANGELOG (#9501) Add step-by-step instructions of the Crowdin releases process (#9555) Fix translated attributes field type change (#9547) Add `modifyList` option to the autocomplete element (#9548) Admin log filters (#9460) Improve the default gitignore files created by the generators (#9507)
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Add `modifyList` option to the autocomplete element * Increase the max-lines eslint rule to fix the linting issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While upgrading term customizer, I noticed that there is no event triggered when the autocomplete result list is updated if it is already open. This required some hacky ways to listen to the changes in the list through
MutationObserveras shown here:https://github.com/mainio/decidim-module-term_customizer/blob/cb170d6e88ada190bf5f6946ad5f688995b6cffb/app/packs/src/decidim/term_customizer/admin/translations_admin.js#L66-L72
This PR provides a new
modifyListoption for the autocomplete which is called every time when the list is modified, i.e. updated. This would've allowed avoiding such hack in the term customizer.In other words, this exposes the
resultsList.elementoption at the autocomplete.js to the Decidim autocomplete implementation, as explained at:https://tarekraafat.github.io/autoComplete.js/#/configuration?id=resultslist-optional
📌 Related Issues
Testing
Try to listen to an event in the autocomplete element without a
MutationObserver.