Fix translated attributes field type change#9547
Merged
andreslucena merged 2 commits intodecidim:developfrom Jul 13, 2022
Merged
Fix translated attributes field type change#9547andreslucena merged 2 commits intodecidim:developfrom
andreslucena merged 2 commits intodecidim:developfrom
Conversation
andreslucena
approved these changes
Jul 13, 2022
Contributor
|
@andreslucena we are facing some issues in 0.26 stable that this PR would solve. If you are planning a 0.26.3 release, I can create the backport |
entantoencuanto
added a commit
that referenced
this pull request
Jul 15, 2022
…ging * feature/redesign-main-footer: Reorder elements in main links of footer and define links and texts Define a cell for static_pages and topics configured to appear in footer Fix translation call Set fixed links in redesigned_main_legal partial Add FooterMenuPresenter to display menu items in footer Fix budgets seeds on non development apps (#9585) Return 404 when there isn't a valid component in program (#9576) Add missing queue close_meeting_reminder to sidekiq configuration (#9568) Make the HERE Map display in the currently selected language (#9552) Add help text for proposals' 'publish answers immediately' setting (#9549) Fix admin language selector with more than 4 locales (#9519) Fix publish event on official proposals (#9421) Prevent missing ActionLog entries to break the application (#9502) Add boilerplate structure to CHANGELOG (#9501) Add step-by-step instructions of the Crowdin releases process (#9555) Fix translated attributes field type change (#9547) Add `modifyList` option to the autocomplete element (#9548) Admin log filters (#9460) Improve the default gitignore files created by the generators (#9507)
This was referenced Aug 15, 2022
Member
@ferblape it's already backported and merged. I don't know if there's any plan to make the 0.26.3 release in the short term. Meanwhile, you can point to the release/0.26-stable branch, of course. |
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Fix issue when the attribute is changed from string to translatable * Test the translated attribute conversion when the original value is a string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The translated attributes getter does not properly work in case the original stored value for the record is not in the expected hash format. This is annoying when changing the field type from string to translated e.g. in content blocks as this breaks the editing view.
This fixes the problem by checking if the stored value is a hash and returning the original value for all locale specific getters in case this happens.
Testing