Skip to content

Add step-by-step instructions of the Crowdin releases process#9555

Merged
ahukkanen merged 6 commits intodevelopfrom
docs/releases-crowdin
Jul 13, 2022
Merged

Add step-by-step instructions of the Crowdin releases process#9555
ahukkanen merged 6 commits intodevelopfrom
docs/releases-crowdin

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

This PR adds step-by-step instructions on how to handle the releases process with Crowdin. There are a couple Crowdin quirks that's good to have documented; at least I remember that the first time that I stumbled upon these particularities was a bit weird.

♥️ Thank you!

@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jul 8, 2022
@andreslucena andreslucena changed the title Add first step to merge the crowdin PRs before starting the release process Add step by step instructions on the Crowdin process Jul 8, 2022
@andreslucena andreslucena changed the title Add step by step instructions on the Crowdin process Add step-by-step instructions on the Crowdin process Jul 8, 2022
@andreslucena andreslucena changed the title Add step-by-step instructions on the Crowdin process Add step-by-step instructions of the Crowdin releases process Jul 8, 2022
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Added some refinements.

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
@andreslucena
Copy link
Copy Markdown
Member Author

Regarding the two suggestions about the hours in v0.27 case, a couple of comments:

  1. I think that was mainly because we haven't merged develop before making the branch. Seeing the history of .decidim-version, I see that just before changing this file (and starting the release process) we usually merge the Crowdin PR, that day or the day before. That's what I did last release, but as far as I see, others maintainers have done the same in the past. As I said, this step in the release process wasn't documented.
  2. If this isn't done, I suppose that Crowdin has to compare all the translation against the two branches the two times + the old release branch.
  3. On this particular case of v0.27.0.rc1, as Crowdin doesn't give too much information of what's happening during the synchronization process, I thought that I had hanged, and I relaunched, so it actually shouldn't take that long. As we hadn't merged the old release branch neither, that was another reason why it was slow too.

As a summary, my theory is that Crowdin synchronization slows down if there are lots of strings to be merged between the branch and what Crowdin has in their database.

But, as this is just a theory and until the next release we can't try if it's fixed with this new step, I think it's safer to accept your suggestions. Later, if we see that this theory is correct, we can always change the documentation.

andreslucena and others added 2 commits July 13, 2022 15:47
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
@andreslucena andreslucena requested a review from ahukkanen July 13, 2022 13:48
@ahukkanen
Copy link
Copy Markdown
Contributor

As a summary, my theory is that Crowdin synchronization slows down if there are lots of strings to be merged between the branch and what Crowdin has in their database.

Thanks for the explanation, makes sense! Let's improve during next release.

@ahukkanen ahukkanen merged commit fa76982 into develop Jul 13, 2022
@ahukkanen ahukkanen deleted the docs/releases-crowdin branch July 13, 2022 16:29
entantoencuanto added a commit that referenced this pull request Jul 15, 2022
…ging

* feature/redesign-main-footer:
  Reorder elements in main links of footer and define links and texts
  Define a cell for static_pages and topics configured to appear in footer
  Fix translation call
  Set fixed links in redesigned_main_legal partial
  Add FooterMenuPresenter to display menu items in footer
  Fix budgets seeds on non development apps (#9585)
  Return 404 when there isn't a valid component in program (#9576)
  Add missing queue close_meeting_reminder to sidekiq configuration (#9568)
  Make the HERE Map display in the currently selected language (#9552)
  Add help text for proposals' 'publish answers immediately' setting  (#9549)
  Fix admin language selector with more than 4 locales (#9519)
  Fix publish event on official proposals (#9421)
  Prevent missing ActionLog entries to break the application (#9502)
  Add boilerplate structure to CHANGELOG (#9501)
  Add step-by-step instructions of the Crowdin releases process (#9555)
  Fix translated attributes field type change (#9547)
  Add `modifyList` option to the autocomplete element (#9548)
  Admin log filters (#9460)
  Improve the default gitignore files created by the generators (#9507)
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
…m#9555)

* Add first step to merge the crowdin PRs before starting the release process

* Add step by step instructions on the Crowdin process

* Fix formatting

* Change URL to return PR based on develop branch only

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Add slow synchronization notice

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Add slow synchronization notice

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants