Skip to content

Add missing queue close_meeting_reminder to sidekiq configuration#9568

Merged
ahukkanen merged 2 commits intodevelopfrom
fix/add-close-meeting-reminder-queue-to-sidekiq
Jul 15, 2022
Merged

Add missing queue close_meeting_reminder to sidekiq configuration#9568
ahukkanen merged 2 commits intodevelopfrom
fix/add-close-meeting-reminder-queue-to-sidekiq

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR adds a queue missing in the sidekiq configuration list of queues: close_meeting_reminder

📌 Related Issues

Testing

When you generate a new app, that queue should exist.

@ferblape ferblape marked this pull request as draft July 13, 2022 09:42
@ferblape
Copy link
Copy Markdown
Contributor Author

Moving to draft because I'd like to add a test that checks the list of queues in the template sidekiq.yml.erb file reading dynamically from [ActionMailer::Base.deliver_later_queue_name, ActiveJob::Base.default_queue_name]

@ferblape ferblape marked this pull request as ready for review July 14, 2022 13:14
@ferblape
Copy link
Copy Markdown
Contributor Author

I couldn't find a way to ready dynamically the queues I don't understand why (we do read that in one of our apps to check the sidekiq.yml is synchronized with the queues names). But it can be implemented later as an improvement to this PR

@ahukkanen ahukkanen added type: fix PRs that implement a fix for a bug module: generators labels Jul 15, 2022
@ahukkanen ahukkanen merged commit b5e19eb into develop Jul 15, 2022
@ahukkanen ahukkanen deleted the fix/add-close-meeting-reminder-queue-to-sidekiq branch July 15, 2022 12:24
entantoencuanto added a commit that referenced this pull request Jul 15, 2022
…ging

* feature/redesign-main-footer:
  Reorder elements in main links of footer and define links and texts
  Define a cell for static_pages and topics configured to appear in footer
  Fix translation call
  Set fixed links in redesigned_main_legal partial
  Add FooterMenuPresenter to display menu items in footer
  Fix budgets seeds on non development apps (#9585)
  Return 404 when there isn't a valid component in program (#9576)
  Add missing queue close_meeting_reminder to sidekiq configuration (#9568)
  Make the HERE Map display in the currently selected language (#9552)
  Add help text for proposals' 'publish answers immediately' setting  (#9549)
  Fix admin language selector with more than 4 locales (#9519)
  Fix publish event on official proposals (#9421)
  Prevent missing ActionLog entries to break the application (#9502)
  Add boilerplate structure to CHANGELOG (#9501)
  Add step-by-step instructions of the Crowdin releases process (#9555)
  Fix translated attributes field type change (#9547)
  Add `modifyList` option to the autocomplete element (#9548)
  Admin log filters (#9460)
  Improve the default gitignore files created by the generators (#9507)
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
…cidim#9568)

* Add missing queue close_meeting_reminder

* Fix offense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: generators type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants