Skip to content

Replace various autocomplete solutions#8524

Merged
andreslucena merged 74 commits intodecidim:developfrom
mainio:refactor/autocomplete
Jan 24, 2022
Merged

Replace various autocomplete solutions#8524
andreslucena merged 74 commits intodecidim:developfrom
mainio:refactor/autocomplete

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Nov 17, 2021 •
edited
Loading

🎩 What? Why?

Replacing various autocomplete solutions with autoComplete.js.

Following fields use now autoComplete.js:

Notice that:

  • Templates uses now datalist instead of autocomplete. Changed this because autoComplete.js doesn't have "default options" by default and old solution was odd IMO because it gave default options only when the input was focused first time.

📌 Related Issues

#8235

Testing

Participant UI

  • Conversations -> New conversation
  • Geocoding (e.g. new proposal -> has address and create meeting -> address)

Admin panel

  • Manage assembly members
  • Conference invites
  • Manage conference speakers
  • Meetings admin invites
  • Elections trustees selection
  • Elections monitoring committee selection
  • Elections polling officers selection

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

image

image

♥️ Thank you!

@lahdeero lahdeero changed the title Refactor/autocomplete Replacing various autocomplete solutions Nov 17, 2021
@lahdeero lahdeero changed the title Replacing various autocomplete solutions Replace various autocomplete solutions Nov 17, 2021
@lahdeero
Implement to add conversation users
124158a
@lahdeero
Seperate admin and participant solutions
0072d95
@lahdeero
Admin can add new assembly member
1669163
@lahdeero
Works like a charm
35bb2b5
@lahdeero
Replace react autocomplete in admin panel
4f5338d
@lahdeero
Add conversation offers max 10 results
c767b66
@lahdeero
Reimplement geocoding autocomplete
69d1053
@lahdeero
Admin autoselect if form fails
ec3ccd7
@lahdeero
Change selected background color
01fd0ca
@lahdeero
Autocomplete component
d1bf274
@lahdeero
Use contract in admin panel
b90d7a9
@lahdeero
Fix css and bugs
03e6bbf
@lahdeero
Mimic react autocomplete
88e17dc
@lahdeero
Remove comment
0d46d5c
@lahdeero
Cleaning and refactoring
77c1a0f
@lahdeero
Clean css and fix geocoding cordinates
da058ff
@lahdeero
Update test helper
851aea9 
- React_select -> autocomplete_select
- Remove jquery autocomplete dependency
- Rename autocomplete_picker -> admin_autocomplete
@lahdeero
Fix stylelint errors
8dcb4ea
@lahdeero
Match with secondary configurations
9161635
@lahdeero
Use datalist in questionnaire template select
ecb7356
@lahdeero
Fix rspec support geocoder
d572956
@lahdeero
Fix template preview
63363d5
@lahdeero
Update package-lock.json
0bacac6
@lahdeero
Fix apply template test
420bff2
@lahdeero
Change less lines in geocoding
0e190e6
@lahdeero
Fix map examples
e1b44d0
@lahdeero
Disable list item when directMessagesDisabled
a0df3dd
@lahdeero
Replace old input multiple mentions
2710310
@lahdeero
Copy link
Copy Markdown
Contributor Author

lahdeero commented Jan 19, 2022 •
edited
Loading

@andreslucena The requested changes has been made! 🙏

@andreslucena andreslucena added the dependencies Pull requests that update a dependency file or issues that talk about updating dependencies label Jan 21, 2022
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Jan 21, 2022

@lahdeero awesome, we're really close!!

I reviewed all the mini CSS bugs that I've found, and they're all fixed. Just a thing regarding the last one (Can't replace an existing autocompleted value in admin), when I start to write I see the letters behind the selected name for like one second and feels weird. Is it possible that when I enter just a character, it's removed? (I think that this is how it works until now)

autocomplete-replace-overwrite.mp4

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Jan 24, 2022

Great PR 👏🏽 👏🏽

@andreslucena andreslucena merged commit ffb78a4 into decidim:develop Jan 24, 2022
@lahdeero lahdeero deleted the refactor/autocomplete branch January 24, 2022 08:27
andreslucena pushed a commit that referenced this pull request Jan 25, 2022
@ahukkanen @andreslucena
Replace various autocomplete solutions (#8524)
7d481b3 
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
@alecslupu alecslupu mentioned this pull request Jan 28, 2022
Closed
@andreslucena andreslucena linked an issue Jan 28, 2022 that may be closed by this pull request
Swap react-select to a vanilla JS autocomplete library #8515
Closed
@andreslucena andreslucena mentioned this pull request Feb 2, 2022
Merged
12 tasks
@ahukkanen ahukkanen mentioned this pull request Feb 23, 2022
Merged
12 tasks
@ahukkanen ahukkanen mentioned this pull request Mar 11, 2022
Merged
12 tasks
@ahukkanen ahukkanen mentioned this pull request Jul 7, 2022
Merged
This was referenced Aug 1, 2022
Closed
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
@andreslucena andreslucena mentioned this pull request Nov 2, 2023
Merged
@ahukkanen ahukkanen mentioned this pull request Feb 17, 2024
Merged
@fblupi fblupi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen requested changes

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies in-review target: developer-experience

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

Swap react-select to a vanilla JS autocomplete library

4 participants

@lahdeero @andreslucena @ahukkanen @alecslupu