Skip to content

Give admin panel access to monitoring committee members#7843

Merged
mrcasals merged 4 commits intodevelopfrom
feat/give-admin-panel-access-to-monitoring-committee-members
Apr 21, 2021
Merged

Give admin panel access to monitoring committee members#7843
mrcasals merged 4 commits intodevelopfrom
feat/give-admin-panel-access-to-monitoring-committee-members

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Apr 15, 2021

🎩 What? Why?

This PR:

  • adapts the Voting's permissions to allow a Monitoring Committee Member to access the admin dashboard;
  • gives the a Monitoring Committee Member the permissions to view a Voting's details (but not update them);
  • gives the a Monitoring Committee Member the permissions to manage the electoral Certificates (empty scaffold for the moment);
  • does not give to the admin users permissions to manage the electoral Certificates (unless they also are Monitoring Committee Members for the given Voting);

Notice that the MonitoringCommitteeCertificatesController is an empty placeholder for the moment and will be considerably reshaped in follow-up PRs. Same goes with its related views.

📌 Related Issues

Link your PR to an issue

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

monitoring.committee.admin.dashoard.mov

♥️ Thank you!

@leio10 leio10 added project: e-voting Barcelona City Council contract module: elections labels Apr 16, 2021
@orlera orlera force-pushed the feat/give-admin-panel-access-to-monitoring-committee-members branch from 97f1c5b to 8cefe88 Compare April 16, 2021 14:18
@orlera orlera force-pushed the feat/give-admin-panel-access-to-monitoring-committee-members branch 2 times, most recently from 94cf381 to 8ea675a Compare April 16, 2021 15:18
@orlera orlera force-pushed the feat/give-admin-panel-access-to-monitoring-committee-members branch from 8ea675a to 40e81e8 Compare April 16, 2021 15:20
@orlera orlera self-assigned this Apr 19, 2021
@orlera orlera force-pushed the feat/give-admin-panel-access-to-monitoring-committee-members branch from dbe4f34 to e96347c Compare April 19, 2021 10:42
@orlera orlera force-pushed the feat/give-admin-panel-access-to-monitoring-committee-members branch from e96347c to 1524247 Compare April 19, 2021 12:55
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 👍

Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 good work!

@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Apr 21, 2021

@decidim/mantainers this can be reviewed 🔍 codecov/patch is falling short because we're missing some specs for MonitoringCommitteeCertificatesController, that will be implemented (and tested) in follow-up PRs.

@orlera orlera marked this pull request as ready for review April 21, 2021 08:58
@mrcasals mrcasals merged commit 1196fb2 into develop Apr 21, 2021
@mrcasals mrcasals deleted the feat/give-admin-panel-access-to-monitoring-committee-members branch April 21, 2021 12:40
entantoencuanto added a commit that referenced this pull request Apr 23, 2021
* develop:
  Upgrade decidim-bulletin_board to 0.20.0 (#7881)
  New Crowdin updates (#7870)
  Fix editor: shift+enter makes single br tag before link (#7877)
  Fix TypeError in newsletters (#7872)
  Give admin panel access to monitoring committee members (#7843)
  New Crowdin updates (#7869)
  New Crowdin updates (#7864)
  Onboarding workflow after voting (#7839)
  Fix filter by scopes (#7858)
  Redirect unauthenticated users to sign in page for unauthorized views (#7852)
  New Crowdin updates (#7861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants