Skip to content

Onboarding workflow after voting#7839

Merged
mrcasals merged 6 commits intodevelopfrom
feature/onboarding-workflow-after-voting
Apr 20, 2021
Merged

Onboarding workflow after voting#7839
mrcasals merged 6 commits intodevelopfrom
feature/onboarding-workflow-after-voting

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Apr 14, 2021

🎩 What? Why?

Since it is possible to vote without having an active Decidim account (as long as the participant is inside the census), this PR adds the option to create an account. There are two options. The first one shows the onboarding modal after the participant filled in the feedback. That's the case, if the questionnaire of the election has questions. If there aren't any questions, the modal appears when going back to the elections page. Both times only when the user isn't logged in.

📌 Related Issues

Link your PR to an issue

Testing

There are several options:

  1. Login as an admin and go to an upcoming election inside the voting space. Vote. If the election has a questionnaire with questions, give feedback and submit the form. You should be redirected to the election page. No onboarding modal should appear.
  2. If the election doesn't have a questionnaire with questions, the page, that informs the admin that the vote got cast, shouldn't have the link to the feedback form. Click the button to go back to elections. No onboarding modal should appear.
  3. As an admin, set up an election and upload a census.
  4. Logout and vote in this election. For that, you have to fill in the correct census data. After the vote got cast, the options as mentioned before (the questionnaire has questions, or it doesn't) are the same. This time, you should see the onboarding modal. You can create a profile or close it.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@slickepinne slickepinne added project: e-voting Barcelona City Council contract module: elections labels Apr 14, 2021
@slickepinne slickepinne self-assigned this Apr 14, 2021
@slickepinne slickepinne force-pushed the feature/onboarding-workflow-after-voting branch from 2c4df4f to 005a9be Compare April 14, 2021 15:05
orlera
orlera previously approved these changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done ⛴️

agustibr
agustibr previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work!

Left some comments on button attributes, and the javascript_include_tag placement.

leio10
leio10 previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔝

@slickepinne slickepinne dismissed stale reviews from leio10, agustibr, and orlera via 2262fa1 April 15, 2021 11:06
@slickepinne slickepinne force-pushed the feature/onboarding-workflow-after-voting branch from 005a9be to 2262fa1 Compare April 15, 2021 11:06
beagleknight
beagleknight previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and tests 🧪 !

@slickepinne slickepinne force-pushed the feature/onboarding-workflow-after-voting branch from 073b629 to ee9ace7 Compare April 20, 2021 13:53
@slickepinne slickepinne marked this pull request as ready for review April 20, 2021 14:23
@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Apr 20, 2021

Hi @decidim/mantainers, this is ready to get reviewed. 😊

@mrcasals mrcasals merged commit 2485504 into develop Apr 20, 2021
@mrcasals mrcasals deleted the feature/onboarding-workflow-after-voting branch April 20, 2021 14:26
orlera pushed a commit that referenced this pull request Apr 22, 2021
@slickepinne
Onboarding workflow after voting (#7839)
ea3e9f1
orlera pushed a commit that referenced this pull request Apr 22, 2021
@slickepinne
Onboarding workflow after voting (#7839)
001ca9e
entantoencuanto added a commit that referenced this pull request Apr 23, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
e099ec2 
* develop:
  Upgrade decidim-bulletin_board to 0.20.0 (#7881)
  New Crowdin updates (#7870)
  Fix editor: shift+enter makes single br tag before link (#7877)
  Fix TypeError in newsletters (#7872)
  Give admin panel access to monitoring committee members (#7843)
  New Crowdin updates (#7869)
  New Crowdin updates (#7864)
  Onboarding workflow after voting (#7839)
  Fix filter by scopes (#7858)
  Redirect unauthenticated users to sign in page for unauthorized views (#7852)
  New Crowdin updates (#7861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@orlera orlera orlera left review comments

@mrcasals mrcasals mrcasals approved these changes

@beagleknight beagleknight beagleknight left review comments

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@slickepinne slickepinne

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Have an on boarding workflow after voting

6 participants

@slickepinne @beagleknight @agustibr @leio10 @mrcasals @orlera