Merged
Conversation
mrcasals
added a commit
that referenced
this pull request
Apr 21, 2021
mrcasals
added a commit
that referenced
this pull request
Apr 21, 2021
orlera
pushed a commit
that referenced
this pull request
Apr 22, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 23, 2021
* develop: Upgrade decidim-bulletin_board to 0.20.0 (#7881) New Crowdin updates (#7870) Fix editor: shift+enter makes single br tag before link (#7877) Fix TypeError in newsletters (#7872) Give admin panel access to monitoring committee members (#7843) New Crowdin updates (#7869) New Crowdin updates (#7864) Onboarding workflow after voting (#7839) Fix filter by scopes (#7858) Redirect unauthenticated users to sign in page for unauthorized views (#7852) New Crowdin updates (#7861)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Sometimes, when sending a newsletter, a
TypeErrorexception is raised. This is due to a method returningnilinstead of an empty list.This PR fixes the problem. Bug seems to be introduced in #7046 and related backports.
Error example: https://sentry.io/share/issue/7bcc9e62a01b44519d6a525ea9a4a447/
📌 Related Issues
None
Testing
Ensure CI is green.