Skip to content

Fix editor: shift+enter makes single br tag before link#7877

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/editor_linebreak_before_link
Apr 22, 2021
Merged

Fix editor: shift+enter makes single br tag before link#7877
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/editor_linebreak_before_link

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Editor creates double linebreak when pressing shift+enter between text and link.

Testing

  1. find WYSIWYG editor, (for example: /admin/organization/edit)
  2. clear all text
  3. write: foo<shift+enter>bar
  4. select bar and make it a link
  5. put cursor end of foo
  6. you should have something like this:
    foo_bar
  7. press shift+enter

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Apr 22, 2021
@mrcasals mrcasals merged commit 217f895 into decidim:develop Apr 22, 2021
entantoencuanto added a commit that referenced this pull request Apr 23, 2021
* develop:
  Upgrade decidim-bulletin_board to 0.20.0 (#7881)
  New Crowdin updates (#7870)
  Fix editor: shift+enter makes single br tag before link (#7877)
  Fix TypeError in newsletters (#7872)
  Give admin panel access to monitoring committee members (#7843)
  New Crowdin updates (#7869)
  New Crowdin updates (#7864)
  Onboarding workflow after voting (#7839)
  Fix filter by scopes (#7858)
  Redirect unauthenticated users to sign in page for unauthorized views (#7852)
  New Crowdin updates (#7861)
@ahukkanen ahukkanen deleted the fix/editor_linebreak_before_link branch May 11, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants