Skip to content

Send email with order summary on order checkout#6006

Merged
tramuntanal merged 8 commits intodevelopfrom
budgets/confirmation-on-order-checkout
Apr 22, 2020
Merged

Send email with order summary on order checkout#6006
tramuntanal merged 8 commits intodevelopfrom
budgets/confirmation-on-order-checkout

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Apr 21, 2020

🎩 What? Why?

This PR adds an email with the summary of the voted budgets projects on order checkout.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Send email with summary on order checkout
  • Add tests for email

📷 Screenshots (optional)

Email from a component not related to a scope:

image

Email from a component related to a scope (see #5941):

image

@mrcasals mrcasals added status: WIP project: PAM2020 Barcelona City Council contract labels Apr 21, 2020
@mrcasals mrcasals self-assigned this Apr 21, 2020
@mrcasals mrcasals force-pushed the budgets/confirmation-on-order-checkout branch 2 times, most recently from b00673b to 32b94df Compare April 21, 2020 10:06
@mrcasals mrcasals force-pushed the budgets/confirmation-on-order-checkout branch from 32b94df to 5257567 Compare April 21, 2020 13:17
@mrcasals mrcasals changed the title [WIP] Send email with order summary on order checkout Send email with order summary on order checkout Apr 21, 2020
@mrcasals mrcasals marked this pull request as ready for review April 21, 2020 13:49
@mrcasals mrcasals mentioned this pull request Apr 21, 2020
1 task
@mrcasals
Copy link
Copy Markdown
Contributor Author

I've updated the description with an example of an email from a component related to a district (see #5941)

@mrcasals mrcasals requested a review from leio10 April 21, 2020 14:12
leio10
leio10 previously approved these changes Apr 21, 2020
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tramuntanal tramuntanal linked an issue Apr 21, 2020 that may be closed by this pull request
1 task
tramuntanal
tramuntanal previously approved these changes Apr 21, 2020
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tramuntanal tramuntanal dismissed their stale review April 21, 2020 15:03

"Lint / Lint code" test are failing

@tramuntanal
Copy link
Copy Markdown
Contributor

Hi @mrcasals can you please check "Lint / Lint code" tests please?

@mrcasals
Copy link
Copy Markdown
Contributor Author

@tramuntanal thanks! I've push a fix! Can you re-review?

@tramuntanal
Copy link
Copy Markdown
Contributor

@mrcasals tests are still failing 😢

@tramuntanal
Copy link
Copy Markdown
Contributor

Ups, no, I was wrong in my previous comment. It was that the screen did not fully updated.

@tramuntanal tramuntanal merged commit 0ebf392 into develop Apr 22, 2020
@tramuntanal tramuntanal deleted the budgets/confirmation-on-order-checkout branch April 22, 2020 09:25
faithngetich pushed a commit to faithngetich/decidim that referenced this pull request Apr 28, 2020
* Send email with order summary on order checkout

* Add changelog

* Simplify code

* Fix locales

* Fix logic

* Lint files

* Trigger build
ace pushed a commit to aspgems/decidim that referenced this pull request Apr 29, 2020
* develop: (65 commits)
  Add newsletter templates (decidim#5887)
  Send email with order summary on order checkout (decidim#6006)
  Change small details on documentation (decidim#5890)
  feat(budgets): Projects filter by multiple categories (decidim#5992)
  Participant renewable verifications (decidim#5854)
  Update .simplecov (decidim#5949)
  Remove legacy assembly types (decidim#5617)
  Don't follow the header x forwarded host by default (decidim#5899)
  Add two CTA on initiative (decidim#5838)
  Conversations with more than one participant (decidim#5861)
  Fix supported versions in SECURITY.md (decidim#5957)
  Add a parameter to specify a list of whitelist ip on /system (decidim#5669)
  Fix error 500 when showing new debate notifications (decidim#5964)
  Upgrade sassc and sassc-rails dependency (decidim#5910)
  Add minimum projects rule to Budgets (decidim#5865)
  Update changelog with current develop
  Fix bad formatted changelog entries
  fix move proposal endorsements migration (decidim#5953)
  Fix the scopes picker rendereding escaped characters (decidim#5939)
  Revert "Fix the scopes picker rendereding escaped characters (decidim#5793)" (decidim#5937)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review project: PAM2020 Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve finish page on Budgets

4 participants