Skip to content

Filter Projects by multiple categories in budgets public view#5992

Merged
tramuntanal merged 2 commits intodevelopfrom
feat/budgets_filter_multiple_categories
Apr 21, 2020
Merged

Filter Projects by multiple categories in budgets public view#5992
tramuntanal merged 2 commits intodevelopfrom
feat/budgets_filter_multiple_categories

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Apr 16, 2020

🎩 What? Why?

Add a checkbox tree for categories in the project filter to allow filtering by multiple categories.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

Screenshot 2020-04-16 at 11 09 59

before:
Screenshot 2020-04-16 at 13 14 24

@agustibr agustibr added the project: PAM2020 Barcelona City Council contract label Apr 16, 2020
@agustibr agustibr force-pushed the feat/budgets_filter_multiple_categories branch from df1d5e8 to 85afb3e Compare April 16, 2020 07:14
@agustibr agustibr changed the title feat(budgets): filter multiple categories feat(budgets): Projects filter by multiple categories Apr 16, 2020
@agustibr agustibr self-assigned this Apr 16, 2020
@agustibr agustibr marked this pull request as ready for review April 16, 2020 11:21
@agustibr agustibr requested review from leio10 and mrcasals April 16, 2020 11:21
leio10
leio10 previously approved these changes Apr 16, 2020
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for doing this! ❤️ 👍

@agustibr agustibr force-pushed the feat/budgets_filter_multiple_categories branch from 8c20780 to 598cab5 Compare April 16, 2020 13:03
@mrcasals
Copy link
Copy Markdown
Contributor

Coverage seems lower than expected, but I think it's due to what's fixed in #5991.

mrcasals
mrcasals previously approved these changes Apr 17, 2020
@agustibr
Copy link
Copy Markdown
Contributor Author

@mrcasals I think so, as the changes only affect Budgets and the coverage fails are from other modules, once #5991 is merged 🤞 into develop I'll merge and update this PR to update the coverage 😁

@agustibr agustibr force-pushed the feat/budgets_filter_multiple_categories branch from 598cab5 to 63d123d Compare April 17, 2020 12:27
@agustibr
Copy link
Copy Markdown
Contributor Author

@mrcasals #5991 merged and rebased branch, all green now 😃

@agustibr agustibr requested review from a team and tramuntanal April 17, 2020 13:50
@agustibr
Copy link
Copy Markdown
Contributor Author

please @decidim/core can you review?

@tramuntanal tramuntanal merged commit 4ac5a74 into develop Apr 21, 2020
@tramuntanal tramuntanal deleted the feat/budgets_filter_multiple_categories branch April 21, 2020 15:22
@tramuntanal tramuntanal changed the title feat(budgets): Projects filter by multiple categories Filter Projects by multiple categories in budgets public view Apr 22, 2020
@tramuntanal
Copy link
Copy Markdown
Contributor

Hi @agustibr I've just updated the title of this PR following the recommendations in https://github.com/decidim/decidim/blob/develop/docs/development_guide.md#git-commit-messages-and-pull-request-titles

faithngetich pushed a commit to faithngetich/decidim that referenced this pull request Apr 28, 2020
* feat(budgets): filter multiple categories

* feat(budgets): filter projects spec
ace pushed a commit to aspgems/decidim that referenced this pull request Apr 29, 2020
* develop: (65 commits)
  Add newsletter templates (decidim#5887)
  Send email with order summary on order checkout (decidim#6006)
  Change small details on documentation (decidim#5890)
  feat(budgets): Projects filter by multiple categories (decidim#5992)
  Participant renewable verifications (decidim#5854)
  Update .simplecov (decidim#5949)
  Remove legacy assembly types (decidim#5617)
  Don't follow the header x forwarded host by default (decidim#5899)
  Add two CTA on initiative (decidim#5838)
  Conversations with more than one participant (decidim#5861)
  Fix supported versions in SECURITY.md (decidim#5957)
  Add a parameter to specify a list of whitelist ip on /system (decidim#5669)
  Fix error 500 when showing new debate notifications (decidim#5964)
  Upgrade sassc and sassc-rails dependency (decidim#5910)
  Add minimum projects rule to Budgets (decidim#5865)
  Update changelog with current develop
  Fix bad formatted changelog entries
  fix move proposal endorsements migration (decidim#5953)
  Fix the scopes picker rendereding escaped characters (decidim#5939)
  Revert "Fix the scopes picker rendereding escaped characters (decidim#5793)" (decidim#5937)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: PAM2020 Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve navigation and visualization of proposals and projects by scope, category, origin and status

4 participants