fix: make codecov report to work on jobs re-run#5991
Merged
tramuntanal merged 3 commits intodevelopfrom Apr 23, 2020
Merged
Conversation
ad89b82 to
ea158f5
Compare
mrcasals
previously approved these changes
Apr 16, 2020
ea158f5 to
f58848f
Compare
f58848f to
1c2574a
Compare
mrcasals
previously approved these changes
Apr 16, 2020
mrcasals
previously approved these changes
Apr 16, 2020
mrcasals
approved these changes
Apr 16, 2020
5 tasks
Contributor
|
Hi @decidim/core! This PR fixes an issue on coverage uploads to Codecov. There's more information on #5954, which tried to fix the same issue but I didn't get enough success. Can you review this PR please? 😄 |
agustibr
approved these changes
Apr 17, 2020
mrcasals
approved these changes
Apr 17, 2020
3 tasks
Contributor
|
@tramuntanal could you review this please? 😄 We keep hiting the same problem on different PRs... 😞 |
tramuntanal
approved these changes
Apr 23, 2020
faithngetich
pushed a commit
to faithngetich/decidim
that referenced
this pull request
Apr 28, 2020
* Use codecov bash uploader instead of gh action * fix: replace + with coalesce operator (//) * fix: remove extra character added by mistake
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Github Actions env variables differ when a check is triggered by different events. This makes the coverage report upload process to fail when a developer forces to re-run a job, as the event is
check_runinstead ofpull_request.This PR replaces the codecov's github action with a direct call to the Codecov bash script, customizing the parameters used (commit SHA and PR identifier) with information extracted directly from the workflow payload, regardless of the event that triggered it. The created script uses
jqqueries to recover the information from the workflow payload and supports thepull_request,pushandcheck_runevents.📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)