Participant renewable verifications#5854
Merged
tramuntanal merged 7 commits intodevelopfrom Apr 21, 2020
Merged
Conversation
9d56d0b to
1db99f6
Compare
662c5d4 to
20ebd16
Compare
andreslucena
requested changes
Mar 13, 2020
mrcasals
previously approved these changes
Mar 13, 2020
leio10
previously approved these changes
Mar 13, 2020
decidim-verifications/lib/decidim/verifications/workflow_manifest.rb
Outdated
Show resolved
Hide resolved
leio10
previously approved these changes
Mar 13, 2020
b8b48a9 to
4b6dad8
Compare
Contributor
|
@agustibr can you try to rebase from develop? This way you'll get a clean workflows build 😄 |
10e0761 to
a74db13
Compare
Contributor
Author
|
@decidim/core this is approved by @decidim/product , please can you review it? cc/ @andreslucena |
665496f to
b931bcf
Compare
andreslucena
previously approved these changes
Mar 31, 2020
Contributor
|
@agustibr , codecov/patch is low. Can you check the diff tab in the Details, and make sure tests cover all lines in red please? |
Contributor
Author
|
@tramuntanal I'm trying to score a higher coverage for the patch. I hope to have it ready tomorrow. |
03763ee to
8e844ad
Compare
Contributor
Author
|
@tramuntanal, added tests and codecov/patch is 100% now 😁 |
8e844ad to
95d147f
Compare
tramuntanal
reviewed
Apr 14, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Good job @agustibr
I'm leaving you small questions and suggestions before accepting
...verifications/app/views/decidim/verifications/authorizations/_granted_authorization.html.erb
Outdated
Show resolved
Hide resolved
decidim-verifications/lib/decidim/verifications/workflow_manifest.rb
Outdated
Show resolved
Hide resolved
95d147f to
3d9daf9
Compare
Contributor
Author
|
@tramuntanal suggested changes applied! |
3d9daf9 to
4a4a1bd
Compare
tramuntanal
approved these changes
Apr 21, 2020
faithngetich
pushed a commit
to faithngetich/decidim
that referenced
this pull request
Apr 28, 2020
* add participant renewable direct verifications * Renewable concern and apply to indirect verifications * Add a confirmation to continue renewal * changes suggested in review * Add renew ajax modal & metadata via workflow * Added more verification specs * apply review suggestions
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
Apr 29, 2020
* develop: (65 commits) Add newsletter templates (decidim#5887) Send email with order summary on order checkout (decidim#6006) Change small details on documentation (decidim#5890) feat(budgets): Projects filter by multiple categories (decidim#5992) Participant renewable verifications (decidim#5854) Update .simplecov (decidim#5949) Remove legacy assembly types (decidim#5617) Don't follow the header x forwarded host by default (decidim#5899) Add two CTA on initiative (decidim#5838) Conversations with more than one participant (decidim#5861) Fix supported versions in SECURITY.md (decidim#5957) Add a parameter to specify a list of whitelist ip on /system (decidim#5669) Fix error 500 when showing new debate notifications (decidim#5964) Upgrade sassc and sassc-rails dependency (decidim#5910) Add minimum projects rule to Budgets (decidim#5865) Update changelog with current develop Fix bad formatted changelog entries fix move proposal endorsements migration (decidim#5953) Fix the scopes picker rendereding escaped characters (decidim#5939) Revert "Fix the scopes picker rendereding escaped characters (decidim#5793)" (decidim#5937) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds the ability to participants to renew verifications, from the account > authorizations.
Once clicked in the verification, opens a modal gives more info to the participant and shows the data used previously, if possible as sometimes data is not stored.
To facilitate developers to show the data of custom authorization methods, the
authorization_metadatais easy to customize through theworkflow.cell_metadatasetting.Each authorization workflow can be configured to be renewable and the time between renewals.
📌 Related Issues
📋 Subtasks
CHANGELOGentrydecidim-generatorverifications initializer📷 Screenshots (optional)