Skip to content

Scopable components#5941

Merged
agustibr merged 9 commits intofeat/budgets-complex-votingsfrom
feat/component_setting_scope
May 13, 2020
Merged

Scopable components#5941
agustibr merged 9 commits intofeat/budgets-complex-votingsfrom
feat/component_setting_scope

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Apr 8, 2020 •
edited
Loading

🎩 What? Why?

  1. feat(admin): add component general setting scope
  • budgets
  • debates
  • meetings
  • proposals
  • surveys
  1. all components use scope related method fallback to its parent (participatory_space or component)
  2. rename/refactor Scopable Concern:
  • Scopable: has all common logic
  • ScopableParticipatorySpace (was Scopable), has the logic related to spaces.
  • ScopableComponent, has the logic related to components
  • ScopableResource (was ScopableComponent), has the logic for resources

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Screenshot 2020-04-08 at 17 31 04

Screenshot 2020-04-08 at 17 31 36

@agustibr agustibr force-pushed the feat/component_setting_scope branch 2 times, most recently from baf9376 to 6cf2116 Compare April 8, 2020 15:29
@agustibr agustibr added project: PAM2020 Barcelona City Council contract status: WIP labels Apr 8, 2020
@agustibr agustibr self-assigned this Apr 8, 2020
@agustibr agustibr linked an issue Apr 8, 2020 that may be closed by this pull request
Configure permissions at district (scope) level for the different components #5708
Closed
1 task
@agustibr agustibr changed the base branch from develop to feat/complex-budgets-voting April 8, 2020 15:34
@agustibr agustibr force-pushed the feat/component_setting_scope branch from 6cf2116 to fb02465 Compare April 9, 2020 05:42
@agustibr agustibr force-pushed the feat/complex-budgets-voting branch from 13508fa to 5004c1f Compare April 9, 2020 05:53
@agustibr agustibr force-pushed the feat/component_setting_scope branch from fb02465 to 8b35add Compare April 9, 2020 05:56
@leio10 leio10 mentioned this pull request Apr 9, 2020
Closed
3 tasks
@agustibr agustibr force-pushed the feat/component_setting_scope branch 3 times, most recently from fd2c521 to c553605 Compare April 16, 2020 06:38
@leio10 leio10 mentioned this pull request Apr 16, 2020
Closed
6 tasks
@leio10 leio10 changed the base branch from feat/complex-budgets-voting to feat/budgets-complex-votings April 16, 2020 11:25
@agustibr agustibr force-pushed the feat/component_setting_scope branch 5 times, most recently from 7f1e66c to 5cea40d Compare April 20, 2020 13:47
@leio10 leio10 force-pushed the feat/budgets-complex-votings branch from 0fce0d8 to 3dbc8b3 Compare April 21, 2020 10:41
@leio10 leio10 force-pushed the feat/component_setting_scope branch from 5cea40d to 8a0cd84 Compare April 21, 2020 10:46
@mrcasals mrcasals mentioned this pull request Apr 21, 2020
Merged
3 tasks
@agustibr agustibr force-pushed the feat/component_setting_scope branch 3 times, most recently from e0ddd87 to 5ac5630 Compare April 24, 2020 09:35
@leio10 leio10 force-pushed the feat/budgets-complex-votings branch from 3dbc8b3 to 9ebb46d Compare April 24, 2020 13:59
@agustibr agustibr force-pushed the feat/component_setting_scope branch 2 times, most recently from deac8ae to 83ff354 Compare April 28, 2020 17:38
@agustibr agustibr force-pushed the feat/component_setting_scope branch from 2f34e04 to 9ecc9c8 Compare May 6, 2020 15:07
@leio10 leio10 force-pushed the feat/budgets-complex-votings branch from 9ebb46d to 09db65a Compare May 7, 2020 10:54
@agustibr agustibr force-pushed the feat/component_setting_scope branch from a0179cb to 2bdad00 Compare May 7, 2020 15:32
@leio10 leio10 force-pushed the feat/budgets-complex-votings branch from 09db65a to 805ddc5 Compare May 8, 2020 09:26
@agustibr agustibr requested review from leio10 and mrcasals May 11, 2020 07:46
mrcasals
mrcasals approved these changes May 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job!

leio10
leio10 approved these changes May 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 💯 👍

decidim-budgets/app/forms/decidim/budgets/admin/project_form.rb
validate :scope_belongs_to_participatory_space_scope

validate :notify_missing_attachment_if_errored
validates :decidim_scope_id, subscope_belongs_to_component: true, if: ->(form) { form.decidim_scope_id.present? }
Copy link
Copy Markdown
Contributor

@leio10 leio10 May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@agustibr agustibr force-pushed the feat/component_setting_scope branch from 5c10202 to 13bff40 Compare May 12, 2020 07:13
@agustibr agustibr changed the title Scopable components: budgets, debates, meetings, proposals, surveys Scopable components May 13, 2020
@agustibr agustibr merged commit 2e4e80b into feat/budgets-complex-votings May 13, 2020
@agustibr agustibr deleted the feat/component_setting_scope branch May 13, 2020 09:17
leio10 pushed a commit that referenced this pull request May 14, 2020
@agustibr @leio10
Scopable components (#5941)
c9f4972
@agustibr agustibr mentioned this pull request May 15, 2020
Merged
6 tasks
leio10 pushed a commit that referenced this pull request May 23, 2020
@agustibr @leio10
Scopable components (#5941)
878d925
leio10 pushed a commit that referenced this pull request May 25, 2020
@agustibr @leio10
Scopable components (#5941)
2468c8d
leio10 added a commit that referenced this pull request May 25, 2020
@leio10
Scopable components (#5941)
cd666bc
@agustibr agustibr restored the feat/component_setting_scope branch July 16, 2020 05:38
@agustibr agustibr mentioned this pull request Jul 16, 2020
Merged
13 tasks
@tramuntanal tramuntanal mentioned this pull request Jul 20, 2020
Merged
29 tasks
@agustibr agustibr deleted the feat/component_setting_scope branch July 28, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@leio10 leio10 leio10 approved these changes

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

project: PAM2020 Barcelona City Council contract status: WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configure permissions at district (scope) level for the different components

3 participants

@agustibr @leio10 @mrcasals