Conversation
3dbc8b3 to
9ebb46d
Compare
2e4e80b to
c9f4972
Compare
f8fec56 to
0c38c86
Compare
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
0c38c86 to
8c80955
Compare
* feat: add workflows to BudgetGroups * feat: allow parent components to define a parent context This context object can be reused in children components controllers, cells, permissions and views, among others when interacting with the parent component. * feat: check parent component permissions on budgets Through the `parent_component_context` the budgets component permissions checks the parent permissions without having to know the type of the parent component. * feat: add configurable texts for budgets groups * refactor: use `view_hooks` to avoid children dependencies with parents * feat: complete cells using parent_component_context from the controller * feat: show "More information" modal at page load when needed Tell the user If vote in the component is not allowed, but they can discard an in-progress order in other component to be allowed to vote in this one. * feat: allow to cancel in-progress orders. * feat: refactor projects views * feat: improve navigation flow when checking out or deleting orders * feat: order components by name when weight and manifest are the same * fix: normalize i18n and address lint issues * fix: repair broken existing tests * fix: address codeclimate issues * fix: avoid warnings raised by JS * fix: address i18n and lint issues * feat: use enum component settings * style: fix i18n and lint issues * test: add test to workflows * test: complete permissions tests * test: add group budgets integration tests * feat: allow to configure more information modal text * style: fix ERB lint issues * chore: move limit_reached? method from base_cell to workflow/base * fix: don't allow voting on components already voted Co-authored-by: Agustí B.R <hola@agusti.cat>
|
Hi @leio10 this PR is WIP and has conflicts but I'm hesitating to start to review it as it is huge. Do you plan to re-take it soon? |
Hi @tramuntanal, we are working on a different approach for this here, so I think we should wait, as this PR probably won't be merged. |
@andreslucena Yes, I close this one.
@tramuntanal , if you want you can start reviewing the refactor PR I hope to finish it this week, you can go commit by commit as the functionality is added progressively. |
🎩 What? Why?
This PR group all the PR related to the implementation of the budgets complex votings flow
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)