Thanks for the comments, clarifications and further fixes @agustibr!

I'll add my notes about changing the budgets listing UI with some examples to #5709, thanks also for pointing it out!

Here's few other notes regarding the UI after further "test driving":

Bug: budgets sorting

The budgets are not listed by their weight attribute in the participant view or the admin panel view:

Bug: more information modal is visible when it is not defined

I noticed the "more information" link is visible with the empty modal window even when the text is not defined for that.

I believe you should add a check here:

As follows:

  def show
    return if more_information.blank?

    render
  end

About the "back to" links

You mentioned the following regarding the "back to" link:

Currently the back link can be found in the more information modal.

I have noticed this but it is extremely difficult to find from there. I wanted to suggest adding it on top of the budgeting view as follows:

This should be only visible when there are more than 1 budget.

Another consistent note we get from UI experts is that the wording "back to" or "back" should be avoided in such links because you cannot assume where the user came from. They could come e.g. from a lift in the front page, from the omniauth banner on top of the site or from a search engine. In such a situation, it can be confusing to the user to use the word "back" because they are not going "back" to where they came from.

Order of messages

I'd like to suggest changing the order of these two messages in the UI:

and:

I think it would make sense to first display "great, now you're done" and after that "here's what you did". Not the other way around.

To fix, just swap the order of these two messages.

Confusing terminology

Active votes

Another change I'd like to suggest is for this term:

I think the wording "active votes" can be confusing to non-technical users. I'd suggest something like:

You have already voted in %{links} or you have started to vote on another budget. To vote on this budget you must delete your vote and start over.

If this does not sound any better, feel free to come up with a better alternative. I'd just like to get rid of the term "active votes" because that be confusing.

"My" budgets?

And this was also what I did not quite understand:

I think this message is not needed, as that section already displays the messages I mentioned above (about changing the term order).

Hi @ahukkanen, thanks again! 😁

The bug sorting budgets by weight is solved in commit a5961d1 in PR #6365.

The suggestions, make sense but I think this should be discussed with @decidim/product as this PR implements the UI approved and present in the decidim_app-design, so I encourage you to open an issue to discuss it further to improve usability.

@decidim/core this has been approved by @decidim/product, can you review it please? 😄

@agustibr OK, I understand regarding the other issues, I'll move them to #5709.

But regarding the more information modal visibility, I believe it could be fixed already for this?

But regarding the more information modal visibility, I believe it could be fixed already for this?

@ahukkanen I didn't hide the more information modal, when there's no info, because it also has the back link inside, it would make total sense to hide it if the back link was outside the modal as you proposed.

Few more bugs I found:

Error when user enters invalid budget or project IDs to the URL

When the user modifies the URL manually and enters invalid ID numbers for budgets or projects, there will be a "server error" on the page. I believe better would be to return a 404 in these cases, e.g. see:

This applies to both index and show actions in Decidim::Budgets::ProjectsController. Also, a similar check should be added to the show action in Decidim::Budgets::BudgetsController.

The user's public timeline is completely broken if the user has left a comment on a budgeting project

• Log in as a user
• Make sure budgeting comments are enabled
• Go to the budgets and open one project
• Leave a comment in that project
• Now, go to your public profile => you will be redirected to the timeline view
• You will see an error on that page (undefined method project_path)

I guess you would need to implement the project_path method on the budgets engine router. Apparently this does not work either (that you've tried?):
f1fafe5#diff-9477c4e74353f50121762aadf11c0951L35

EDIT: This bug also seems to affect the front page timeline block.

Thank you @ahukkanen for the heavy testing you're doing on this feature!
@agustibr can you fix the two problems found?

• Error when user enters invalid budget or project IDs to the URL
• The user's public timeline is completely broken if the user has left a comment on a budgeting project
  • This bug also seems to affect the front page timeline block
    thanks!

Thanks @tramuntanal 😁! (and @ahukkanen)

Yes, I'll push fixes for both.

• Error when user enters invalid budget or project IDs to the URL
• The user's public timeline is completely broken if the user has left a comment on a budgeting project
  • This bug also seems to affect the front page timeline block

@tramuntanal the bugs are solved 😁 , the push dismissed your approval review.

I guess you would need to implement the project_path method on the budgets engine router. Apparently this does not work either (that you've tried?):
f1fafe5#diff-9477c4e74353f50121762aadf11c0951L35

@ahukkanen since #6274 was merged resource_locator is able to generate the path for nested resources:

resource_locator([project.budget, project]).path
# => "/processes/ad-sunt/f/4/budgets/1/projects/1"

So I've refactored to use the resource_locator with nested resources.