feat: add BudgetsGroups component#5924
Merged
leio10 merged 25 commits intofeat/complex-budgets-votingfrom Apr 16, 2020
Merged
Conversation
aeb3891 to
17d280b
Compare
68ff141 to
c4e71da
Compare
Contributor
|
@decidim/core I don't understand how Codecov calculates coverage. At commit 6f9f7ff I have these checks:
Checking the I visit the "Changes" tab: This page lists all the files that have changed coverage. The first file I get is one that has decreased coverage, but is not modified in our PR:
Other files appear as new, but they've been on the repo for a long time now:
Any idea what's going on and what should we do to get this PR green? Alternatively, can we ignore these checks? |
613ba74 to
11e9647
Compare
13508fa to
5004c1f
Compare
e75dd0c to
0164355
Compare
96f6ba9 to
17f58cb
Compare
* Fix supported versions in SECURITY.md * Add changelog entry
A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes.
17f58cb to
c9cd7bc
Compare
leio10
added a commit
that referenced
this pull request
Apr 16, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
Apr 16, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
This was referenced Apr 16, 2020
leio10
added a commit
that referenced
this pull request
Apr 21, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
Apr 24, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 7, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 8, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 14, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 14, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 23, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 25, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
leio10
added a commit
that referenced
this pull request
May 25, 2020
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds the BudgetsGroups component to allow grouping different Budgets components on a parent component.
To achieve this, this PR first modify the component model to allow having parent components. After this, it modifies the admin component and all the participatory spaces to make them hide the child components from components list (both in admin and front views). After this, the responsibility of showing the child components is delegated to the parent component.
Finally, this PR adds the new component to the Budgets module, using the namespace Decidim::Budgets::Groups to add all the related classes.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)
Children budget components are shown inside the budgets group component (and not in the component list)
Budget component admin page allows admin users to change its parent component (or to unset it)
Budgets Group index page show links to the budgets components (this has to be improved with cards and highlighting budgets depending on the user scope)