Improve budgets group flow#6031
Merged
leio10 merged 25 commits intofeat/budgets-complex-votingsfrom May 25, 2020
Merged
Conversation
76bb78d to
2b5e9e5
Compare
mrcasals
approved these changes
Apr 28, 2020
Contributor
mrcasals
left a comment
There was a problem hiding this comment.
Loved the workflow strategies!! Looks good to me!
9ebb46d to
09db65a
Compare
701596c to
777d830
Compare
09db65a to
805ddc5
Compare
bb32740 to
f909392
Compare
2e4e80b to
c9f4972
Compare
92598e9 to
b3114b9
Compare
agustibr
reviewed
May 19, 2020
b328478 to
f8fec56
Compare
78a11d5 to
fce978e
Compare
f8fec56 to
0c38c86
Compare
fce978e to
cebc981
Compare
0c38c86 to
8c80955
Compare
This context object can be reused in children components controllers, cells, permissions and views, among others when interacting with the parent component.
Through the `parent_component_context` the budgets component permissions checks the parent permissions without having to know the type of the parent component.
Tell the user If vote in the component is not allowed, but they can discard an in-progress order in other component to be allowed to vote in this one.
cebc981 to
ce03a77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR completes the implementation of complex votings described in #5993. It allows to implement complex workflows to be used by the BudgetsGroup component.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)