Conversation
Current coverage is 95.73% (diff: 100%)@@ master #19 diff @@
==========================================
Files 73 73
Lines 656 656
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 628 628
Misses 28 28
Partials 0 0
|
josepjaume
left a comment
There was a problem hiding this comment.
@beagleknight maybe you could integrate the QA steps into the Readme?
|
@josepjaume Sure but... can I add some templating to the README? 😮 |
|
Oh right! I was referring to the gem's README, but you're right - this should go to the project's Readme instead. We can do it later on, but it should be done at some point. |
| encoding: unicode | ||
| # For details on connection pooling, see rails configuration guide | ||
| # http://guides.rubyonrails.org/configuring.html#database-pooling | ||
| pool: <%%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %> |
| # To create additional roles in postgres see `$ createuser --help`. | ||
| # When left blank, postgres will use the default role. This is | ||
| # the same name as the operating system user that initialized the database. | ||
| #username: <%= app_name %> |
|
|
||
| production: | ||
| adapter: redis | ||
| url: redis://<%%= ENV.fetch("REDIS_HOST") { "localhost" } %>:6379/1 |
There was a problem hiding this comment.
What about using redis_url instead of REDIS_HOST?
There was a problem hiding this comment.
Totally agree :D. I'm including the protocol, port and db as well.
| # For details on connection pooling, see rails configuration guide | ||
| # http://guides.rubyonrails.org/configuring.html#database-pooling | ||
| pool: <%%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %> | ||
| host: <%%= ENV.fetch("DB_HOST") { "localhost" } %> |
There was a problem hiding this comment.
I'd use url instead, and the default value (will look a bit weird):
url: <%%= ENV.fetch("DATABASE_URL") { "url: postgresql://localhost/blog_development?pool=5" } %>There was a problem hiding this comment.
It's cool. On it!
6a59d9b to
544909b
Compare
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix model proposal spec * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Fix error in merge * Delete useless comment * Change proposal state colors to match admin proposal manager with proposal component
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * moved to amendable dir fix docs * Reject Amendment * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Add amendment rejected notifications * Add automatically reject amendments of a withdrawn proposal * Add promoting functionality and promoted amendment notifications * Add reject/promote amendment system spec * Add reject amendment examples and test * Add promote amendment examples and test * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Drop notifications tests until we know how to resolve them * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix proposals_spec * Fix model proposal spec * Fix model proposal spec * Fix rubocop offences * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Refactor promote action/form/command * Refactor thanks to review * Refactor thanks to review Add reject/promote form specs, reject/promote amendment examples traceability tests and fix amend_proposal_spec * Refactor thanks to review Fix rubocop offenses and refactor promotable_by? to be more robust * Fix rubocop offenses * Refactor promotable_by? * Refactor thanks to review Add traceability tests in amendment command specs. Add specs for amendment events. Refactor amendment commands. Refactor `promotable_by?`. * Drop useless line in `promotable_by?` method * Refactor thanks to review Add notification tests in amendment command specs. Fix rubocop offenses. * Refactor thanks to review Refactor amendment action buttons/cells. Moved promoted button into amendments helper. * Fix rubocop offenses * Add enforce_permission_to :promote
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * moved to amendable dir fix docs * Reject Amendment * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Add amendment rejected notifications * Add automatically reject amendments of a withdrawn proposal * Add promoting functionality and promoted amendment notifications * Add reject/promote amendment system spec * Add reject amendment examples and test * Add promote amendment examples and test * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Drop notifications tests until we know how to resolve them * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix proposals_spec * Fix model proposal spec * Fix model proposal spec * Add proposals/emendations control version * Add proposals/emendations control version * Fix rubocop offences * Fix collaborative_drafts_spec * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Refactor promote action/form/command * Fix proposal version author if user group chosen * Fix errors when merging * Fix conflicts when merging * Delete useless method * Refactor publish_proposal * Fix rubocop offenses * Refactor version control documentation * Fix proposals actions on the public view show in admin log * Refactor thanks to review * Refactor thanks to review * Revert rubocop change * Fix traceability test in proposals specs after version control refactor
* Opening commit 🚧 * Allow user to drag address on proposal map * Fix offenses * Fix shared example * Fix proposal spec * Ligh refactor * Fix admin form * Skip test on admin side * Refactor test example * Remove useless message * FIx offenses * add drag cursor map (#19) * merge branch 'develop' * disable rubocop RSpec/EmptyExampleGroup for proposal wizards example * Fix drag cursor ci (#23) * fix failing test * refactor proposals_wizards_examples Co-authored-by: Armand Fardeau <fardeauarmand@gmail.com> * Add map helper spec * Fix test Co-authored-by: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com>
What and why
As requested here #14, I added Docker for
decidimbase gem and for new applications generated with it.QA
Generate a new application using the gem or running it through docker like
docker-compose run --rm decidim --edge new_app.Run the following commands:
docker-compose build: Build the app imagedocker-compose run --rm app bundle exec rake db:create db:migrate: Create and migrate databasedocker-compose up: Launch all the services.Visit
http://localhost:3000.GIF Tax