Conversation
baed992 to
dcd54b0
Compare
Current coverage is 96.33% (diff: 91.66%)@@ master #18 diff @@
==========================================
Files 73 103 +30
Lines 656 901 +245
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 628 868 +240
- Misses 28 33 +5
Partials 0 0
|
127e853 to
f6f8a5d
Compare
Contributor
Author
josepjaume
approved these changes
Sep 27, 2016
| "Decidim" | ||
| end | ||
|
|
||
| def field_name(model, field) |
Contributor
There was a problem hiding this comment.
Remove this as it's not used anymore (actually, it should be gone un decidim-system as well).
f6f8a5d to
073e60e
Compare
Contributor
Author
|
Code Climate issues will be fixed in a separate PR. |
isaacmg410
pushed a commit
that referenced
this pull request
Nov 14, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 14, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
agustibr
added a commit
that referenced
this pull request
Nov 14, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
isaacmg410
pushed a commit
that referenced
this pull request
Nov 21, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
aitorlb
pushed a commit
that referenced
this pull request
Nov 23, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
aitorlb
pushed a commit
that referenced
this pull request
Nov 23, 2018
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
mrcasals
pushed a commit
that referenced
this pull request
Nov 30, 2018
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix model proposal spec * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Fix error in merge * Delete useless comment * Change proposal state colors to match admin proposal manager with proposal component
oriolgual
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * moved to amendable dir fix docs * Reject Amendment * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Add amendment rejected notifications * Add automatically reject amendments of a withdrawn proposal * Add promoting functionality and promoted amendment notifications * Add reject/promote amendment system spec * Add reject amendment examples and test * Add promote amendment examples and test * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Drop notifications tests until we know how to resolve them * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix proposals_spec * Fix model proposal spec * Fix model proposal spec * Fix rubocop offences * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Refactor promote action/form/command * Refactor thanks to review * Refactor thanks to review Add reject/promote form specs, reject/promote amendment examples traceability tests and fix amend_proposal_spec * Refactor thanks to review Fix rubocop offenses and refactor promotable_by? to be more robust * Fix rubocop offenses * Refactor promotable_by? * Refactor thanks to review Add traceability tests in amendment command specs. Add specs for amendment events. Refactor amendment commands. Refactor `promotable_by?`. * Drop useless line in `promotable_by?` method * Refactor thanks to review Add notification tests in amendment command specs. Fix rubocop offenses. * Refactor thanks to review Refactor amendment action buttons/cells. Moved promoted button into amendments helper. * Fix rubocop offenses * Add enforce_permission_to :promote
oriolgual
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * moved to amendable dir fix docs * Reject Amendment * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Add amendment rejected notifications * Add automatically reject amendments of a withdrawn proposal * Add promoting functionality and promoted amendment notifications * Add reject/promote amendment system spec * Add reject amendment examples and test * Add promote amendment examples and test * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Add validate amendment form examples and test * Drop notifications test until we know how to resolve it * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment feature activated in the proposal component admin panel and render Ammend Button * Refactored due to review * Enable UserGroup to Amend * moved to amendable dir fix docs * add @emendation_form to proposals_controller * add evaluating? method * add :emendation and :amendment to EmendationActionsCell * Add Amended by list in amendable detail * Fix Created notice * Use CollapsibleListCell for amendments list * add action_authorized_link_to to amend_button_card * Added Amend system Specs for Creation * configurable amendable fields * Update amendable/create to perform_action * Permit and admin react on an official emmendation * Add "Amendment" label to CardM * add hashtags support * minor improvements for amendables * Fix proposals/emendations state (#17) * Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate * fix rubocop offenses * fix specs and some minor problems to counter cache update * fix codeclimate errors * return to a previous version * make some methods private * run rubocop to fix codeclimate offenses * working with specs * Add create amendment example * Move files * Fix rubocop offenses * Add withdraw amendment examples and test * Add amendments seeds * Add has_footer? method again to fix amendment title links * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment feature activated in the proposal component admin panel and render Ammend Button * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Amendment model, Amendable concern, amendments_list, emendation_announcement, emendation_actions ... * Refactored due to review * Refactored due to review * Refactored due to review * Refactored due to review * Enable UserGroup to Amend * Accept Amendment * fix flash type on accepted error * Added Amend system Specs for Creation * configurable amendable fields * Fix amender can edit proposal if emendation accepted * Fix amender can react to emendations if emendation accepted * Add amendment accepted notifications * Add review form validations * Add accept amendment examples and test * Add accept amendment examples and test * Drop unused locale key * Drop notifications tests until we know how to resolve them * Fix amend_proposal_spec and delete an old test * Fix proposals_spec * Fix proposals_spec * Fix model proposal spec * Fix model proposal spec * Add proposals/emendations control version * Add proposals/emendations control version * Fix rubocop offences * Fix collaborative_drafts_spec * Refactor thanks to review * Refactor thanks to review * Refactor thanks to review * Fix rubocop offenses * Delete useless file * Delete useless files * Add changelog entry and documentation * Refactor thanks to review * Fix mistake when merging/rebasing * Fix Markdown linter offenses * Refactor promote action/form/command * Fix proposal version author if user group chosen * Fix errors when merging * Fix conflicts when merging * Delete useless method * Refactor publish_proposal * Fix rubocop offenses * Refactor version control documentation * Fix proposals actions on the public view show in admin log * Refactor thanks to review * Refactor thanks to review * Revert rubocop change * Fix traceability test in proposals specs after version control refactor
alecslupu
referenced
this pull request
in i-need-another-coffee/decidim
Oct 7, 2020
Update core decidim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Implements #15.
🎯 Acceptance criteria?
👻 GIF