Skip to content

Feature accept amendments proposals on proposals #3985

Merged
mrcasals merged 113 commits intomasterfrom
feature/amendments-proposals-on-proposals-accept
Nov 30, 2018
Merged

Feature accept amendments proposals on proposals #3985
mrcasals merged 113 commits intomasterfrom
feature/amendments-proposals-on-proposals-accept

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Aug 9, 2018 •
edited by aitorlb
Loading

🎩 What? Why?

Add Accept Amendment Functionality to Amendments (proposals)

Include

New

  • Create & withdraw amendments
  • Accept amendments

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests

📷 Screenshots (optional)

  • screenshot from 2018-08-09 12-25-46
  • screenshot from 2018-08-09 12-26-04
  • screenshot from 2018-08-09 12-27-57
  • screenshot from 2018-08-09 12-28-16
  • screenshot from 2018-08-09 12-28-42

@ghost ghost assigned agustibr Aug 9, 2018
@ghost ghost added the status: WIP label Aug 9, 2018
@agustibr agustibr changed the title Feature/amendments proposals on proposals accept Feature accept amendments proposals on proposals Aug 9, 2018
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch 2 times, most recently from 4859010 to 9d846bd Compare August 9, 2018 13:16
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch from cfed622 to 5c06abf Compare August 9, 2018 14:06
@agustibr agustibr mentioned this pull request Aug 9, 2018
Closed
5 tasks
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch 2 times, most recently from a6b52e4 to 94e0041 Compare August 9, 2018 15:21
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch from 9f1738c to 07d884e Compare August 9, 2018 15:27
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch 2 times, most recently from dc97c2f to c06a224 Compare August 13, 2018 08:51
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch 3 times, most recently from 5b58371 to e97a130 Compare August 13, 2018 15:27
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch from c06a224 to bd6b68f Compare August 13, 2018 15:48
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch 6 times, most recently from 3a02c13 to 092c9d2 Compare August 17, 2018 11:44
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch 2 times, most recently from 5be5cd0 to 5db29f8 Compare August 17, 2018 12:10
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch 3 times, most recently from c0575ea to 1ca5f26 Compare August 24, 2018 08:15
@oriolgual
Copy link
Copy Markdown
Contributor

oriolgual commented Aug 27, 2018

@agustibr could you please rebase this?

@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals branch from 1ca5f26 to 7c1e344 Compare August 27, 2018 10:53
@agustibr agustibr force-pushed the feature/amendments-proposals-on-proposals-accept branch from 5db29f8 to d3fb5ab Compare August 29, 2018 14:24
@agustibr agustibr mentioned this pull request Nov 28, 2018
Merged
2 tasks
This was referenced Nov 28, 2018
Merged
Closed
@ghost ghost added the status: WIP label Nov 28, 2018
@ghost ghost added the status: WIP label Nov 29, 2018
@aitorlb
Copy link
Copy Markdown
Contributor

aitorlb commented Nov 29, 2018 •
edited
Loading

@oriolgual are all the reviews resolved? We need this PR to be merged into master as soon as possible. Please, tell me if there's something I can do to shorten the process.

@aitorlb aitorlb mentioned this pull request Nov 29, 2018
Closed
2 tasks
mrcasals
mrcasals previously approved these changes Nov 30, 2018
View reviewed changes
@ghost ghost assigned mrcasals Nov 30, 2018
@ghost ghost added the status: WIP label Nov 30, 2018
@mrcasals mrcasals merged commit 35642a5 into master Nov 30, 2018
@mrcasals mrcasals deleted the feature/amendments-proposals-on-proposals-accept branch November 30, 2018 09:55
@ghost ghost removed the status: WIP label Nov 30, 2018
@agustibr
Copy link
Copy Markdown
Contributor Author

agustibr commented Dec 4, 2018

🎉

This was referenced Dec 4, 2018
Merged
Merged
@agustibr agustibr mentioned this pull request Feb 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carolromero carolromero carolromero left review comments

+4 more reviewers

@oriolgual oriolgual oriolgual left review comments

@tramuntanal tramuntanal tramuntanal left review comments

@aitorlb aitorlb aitorlb left review comments

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

@mrcasals mrcasals

@aitorlb aitorlb

Labels

in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agustibr @oriolgual @aitorlb @tramuntanal @mrcasals @carolromero