Skip to content

Fix foe#19

Closed
alecslupu wants to merge 0 commit intodevelopfrom
fix-foe
Closed

Fix foe#19
alecslupu wants to merge 0 commit intodevelopfrom
fix-foe

Conversation

@alecslupu
Copy link
Copy Markdown

@alecslupu alecslupu commented Oct 15, 2020

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu marked this pull request as draft October 15, 2020 11:16
roxanaopr pushed a commit that referenced this pull request Oct 15, 2020
@alecslupu
Merge pull request #19 from decidim/develop
904a75e 
regular update
alecslupu pushed a commit that referenced this pull request Nov 27, 2020
@armandfardeau @Quentinchampenois
Allow user to drag address on proposal map (decidim#6291)
d458745 
* Opening commit 🚧

* Allow user to drag address on proposal map

* Fix offenses

* Fix shared example

* Fix proposal spec

* Ligh refactor

* Fix admin form

* Skip test on admin side

* Refactor test example

* Remove useless message

* FIx offenses

* add drag cursor map (#19)

* merge branch 'develop'

* disable rubocop RSpec/EmptyExampleGroup for proposal wizards example

* Fix drag cursor ci (#23)

* fix failing test

* refactor proposals_wizards_examples

Co-authored-by: Armand Fardeau <fardeauarmand@gmail.com>

* Add map helper spec

* Fix test

Co-authored-by: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com>
@alecslupu alecslupu added the wontfix This will not be worked on label Feb 5, 2021
@alecslupu alecslupu removed the wontfix This will not be worked on label Aug 31, 2021
@alecslupu alecslupu force-pushed the fix-foe branch 4 times, most recently from ae581c1 to d33ff2f Compare September 30, 2021 18:25
@alecslupu alecslupu changed the base branch from develop to 0.1-stable October 21, 2021 11:35
@alecslupu alecslupu changed the base branch from 0.1-stable to develop October 21, 2021 11:35
@alecslupu alecslupu closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alecslupu