Skip to content

feat: send moderation email when reported content is translated to default language#23

Merged
orlera merged 12 commits intofix-foefrom
feat/send-moderation-email-when-reprted-content-translated
Oct 21, 2020
Merged

feat: send moderation email when reported content is translated to default language#23
orlera merged 12 commits intofix-foefrom
feat/send-moderation-email-when-reprted-content-translated

Conversation

@orlera
Copy link
Copy Markdown

@orlera orlera commented Oct 16, 2020

🎩 What? Why?

When we receive a translation for a reported content, we send an email to the moderators of the content's participatory space.

To be eligible to send emails, the resource has to be:

  • reportable and reported;
  • fully translated in the organization's default language;

Testing

Unit testing in place

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@orlera orlera self-assigned this Oct 16, 2020
@orlera orlera force-pushed the feat/send-moderation-email-when-reprted-content-translated branch from 6deb054 to aa4c447 Compare October 19, 2020 07:54
@orlera orlera changed the base branch from feat/moderation-notifications-improvements to refactor/add-reported-attributes October 19, 2020 11:33
@orlera orlera marked this pull request as ready for review October 19, 2020 14:22
@orlera orlera requested a review from beagleknight October 19, 2020 14:22
Base automatically changed from refactor/add-reported-attributes to fix-foe October 20, 2020 12:43
@orlera orlera requested review from beagleknight and mrcasals and removed request for beagleknight October 21, 2020 12:01
@orlera orlera merged commit 43cd8fe into fix-foe Oct 21, 2020
@orlera orlera deleted the feat/send-moderation-email-when-reprted-content-translated branch October 21, 2020 15:01
@orlera orlera mentioned this pull request Nov 13, 2020
12 tasks
alecslupu pushed a commit that referenced this pull request Nov 27, 2020
* Opening commit 🚧

* Allow user to drag address on proposal map

* Fix offenses

* Fix shared example

* Fix proposal spec

* Ligh refactor

* Fix admin form

* Skip test on admin side

* Refactor test example

* Remove useless message

* FIx offenses

* add drag cursor map (#19)

* merge branch 'develop'

* disable rubocop RSpec/EmptyExampleGroup for proposal wizards example

* Fix drag cursor ci (#23)

* fix failing test

* refactor proposals_wizards_examples

Co-authored-by: Armand Fardeau <fardeauarmand@gmail.com>

* Add map helper spec

* Fix test

Co-authored-by: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants