Allow user to drag address on proposal map by armandfardeau · Pull Request #6291 · decidim/decidim

armandfardeau · 2020-07-10T07:34:53Z

🎩 What? Why?

When geocoding is activated, the user could have an alternative way to enter address positioning the cursor on the map. UX details : In the complete proposal stage when creating a proposal the user could click on a button to position cursor on the map which open a model with a map on which the user could navigate to position pin and validate.

📌 Related Issues

Related to https://meta.decidim.org/processes/roadmap/f/122/proposals/13116

📋 Subtasks

Add tests

📷 Screenshots (optional)

tramuntanal · 2020-07-16T13:23:40Z

Hi @armandfardeau !
Is this related to some issue or feature approved by @decidim/product ? can you link please? 😄

carolromero · 2020-07-16T14:05:30Z

Here @tramuntanal 😊 https://meta.decidim.org/processes/roadmap/f/122/proposals/13116
I haven't been able to review the PR, though. @virgile-dev @armandfardeau Is there somewhere we can take a look? Thank you!

virgile-dev · 2020-07-16T15:15:23Z

@carolromero @tramuntanal here is the related issue : OpenSourcePolitics/dev#27
We'll refactor a bit the feature for this PR but you can test its current behaviour here : https://demo.decidim.opensourcepolitics.eu/processes/modules-decidim/f/2/

tramuntanal · 2020-07-22T09:47:19Z

@virgile-dev @armandfardeau you said you'll "refactor a bit the feature", is the PR ready for review now?

Leusev · 2020-07-22T14:15:48Z

Thanks for this work @armandfardeau .
@decidim/product / @carolromero could you test this improvement in their staging?
Thanks in advance

virgile-dev · 2020-07-22T16:29:03Z

@tramuntanal yes this the refactored version.
We don't a staging environment for this though. Let me check with @armandfardeau if we can have one with here maps activated.

virgile-dev · 2020-07-24T12:41:48Z

@armandfardeau it looks good to me !
Only feedback is the following, could you delete the 2 things I highlighted in the capture bellow please ?

Leusev · 2020-07-27T07:20:43Z

@armandfardeau it looks good to me !
Only feedback is the following, could you delete the 2 things I highlighted in the capture bellow please ?

While I was testing, I found this screen too, but I don't understand very well what is intended for that red highlighted text.
Is there where the draggable map should appear? I also don't quite understand why it tells me it's not geocoded..

Could you briefly explain what steps to follow to activate the option where the draggable map button appears please?

Thanks in advance @armandfardeau !

Leusev

Could you please also review the file conflicts?
Thank you very much!

Leusev · 2020-07-29T07:27:04Z

@armandfardeau it looks good to me !
Only feedback is the following, could you delete the 2 things I highlighted in the capture bellow please ?

While I was testing, I found this screen too, but I don't understand very well what is intended for that red highlighted text.
Is there where the draggable map should appear? I also don't quite understand why it tells me it's not geocoded..

Could you briefly explain what steps to follow to activate the option where the draggable map button appears please?

Thanks in advance @armandfardeau !

Thanks for checking and resolve conflict files @armandfardeau
In other hand, could you briefly explain what steps to follow to activate the option where the draggable map button appears please?
Thanks!

Leusev · 2020-07-29T14:19:38Z

In the meantime, @decidim/product have you been able to test the new functionality?
// cc @carolromero
Thanks!

andreslucena · 2020-08-03T08:08:48Z

I've checked it last week, but found the "not geocoded address" and thought that I had misconfigured my here on localhost and I was waiting for the staging environment to check it out again.

This will need a rework as there are going to be huge changes on the maps API on #6340

virgile-dev · 2020-11-06T10:01:30Z

Hello @carolromero

We revamped this feature updating our code to the changes Antti added in its PR to make maps configurable (#6340 ).
You can test this feature on this staging env : https://staging-map.osp.dev/
Here is an example of a proposal made using the feature : https://staging-map.osp.dev/processes/incidunt-provident/f/12/proposals/46?locale=en the address inputed is vague (a neighbourhood in Paris) and I position my point on a place that has no address per say, which is one of the use case of the feature.
You can test using the test logins user@example.org

Happy testing !
Hoping we can merge this finally 🤞

carolromero · 2020-11-11T08:25:33Z

Hey @virgile-dev I tested this and seems to be working fine. This is a cool feature 😎 thanks!

virgile-dev · 2020-11-13T10:59:09Z

@Leusev this was accepted and tested by product. It's finally ready to be merged 🥳
Thanks in advance !

Leusev

Hi @armandfardeau
in first place, thanks a lot for your work! 😄
In general, seems good for me, but it noticed that codecov/patch is too low

there is a difference in the percentage of missing codecov/patch tests too large...

Could you check if is possible to add/improve a bit the current tests please?
Thanks in advance!

virgile-dev · 2020-11-18T18:14:24Z

@Leusev Armand improved the codecov by a lot. Do you think you can merge it now ? Thanks in advance !

armandfardeau · 2020-11-19T00:33:32Z

@Leusev The Failing initiative test works perfectly locally, could you retry? Looks like a flaky to me.

tramuntanal · 2020-11-19T08:17:32Z

I'm re-running initiatives' workflow

Leusev

All ok now @armandfardeau ! 😄
Thanks a lot for your effort & tests improvement 👍

…ngs_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

…_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

…cipatory_processes_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

…link * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

…ighted_groups * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

…s_and_processes_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...

armandfardeau added 8 commits July 10, 2020 09:33

Opening commit 🚧

2e35164

Allow user to drag address on proposal map

01c6b5b

Fix offenses

851c713

Fix shared example

d061c94

Fix proposal spec

487c3f3

Ligh refactor

1411af2

Fix admin form

ddcc423

Skip test on admin side

1936eac

Refactor test example

698d1cf

armandfardeau marked this pull request as ready for review July 17, 2020 07:12

Leusev self-requested a review July 22, 2020 09:49

Leusev self-assigned this Jul 22, 2020

Leusev added the in-review label Jul 22, 2020

Leusev suggested changes Jul 27, 2020

View reviewed changes

Leusev added module: core module: proposals labels Jul 28, 2020

armandfardeau added 3 commits July 28, 2020 11:38

Remove useless message

0531d1b

Merge branch 'develop' into feature/draggable-cursor-on-proposal-map

750c013

FIx offenses

71351da

armandfardeau marked this pull request as ready for review November 6, 2020 10:03

Leusev removed the status: WIP label Nov 13, 2020

Leusev self-requested a review November 13, 2020 12:12

Leusev suggested changes Nov 13, 2020

View reviewed changes

Add map helper spec

c2bd1d3

Fix test

23d80ee

Leusev approved these changes Nov 25, 2020

View reviewed changes

Leusev merged commit d458745 into decidim:develop Nov 25, 2020

ahukkanen mentioned this pull request Feb 10, 2021

Fix removal of the address from proposals #7343

Merged

12 tasks

mrcasals added the type: feature label Feb 26, 2021

This was referenced Mar 9, 2021

Ausbau Kartenfunktion puzzle/decidim-zuerich#36

Closed

Erweiterung Kartenfunktion stadtluzern/decidim-ocl#40

Open

oliverbarnes mentioned this pull request Mar 16, 2021

Bump the module and the demo to Decidim 0.23 liquidvotingio/decidim-module-liquidvoting#33

Closed

mrcasals mentioned this pull request Mar 18, 2021

Fix rendering of proposals in map #7642

Merged

This was referenced Mar 18, 2021

Refactor map functionality regarding the drag marker maps #7649

Merged

Proposal preview page "update position" button gets higher priority than "Publish" #7676

Closed

Quentinchampenois mentioned this pull request Jun 1, 2021

Fix proposal map form #8088

Merged

Quentinchampenois mentioned this pull request Jun 24, 2021

Fix proposal map for on release/0.24-stable #8160

Merged

12 tasks

Uh oh!

Conversation

armandfardeau commented Jul 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

tramuntanal commented Jul 16, 2020

Uh oh!

carolromero commented Jul 16, 2020

Uh oh!

virgile-dev commented Jul 16, 2020

Uh oh!

tramuntanal commented Jul 22, 2020

Uh oh!

Leusev commented Jul 22, 2020

Uh oh!

virgile-dev commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virgile-dev commented Jul 24, 2020

Uh oh!

Leusev commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Leusev left a comment

Choose a reason for hiding this comment

Uh oh!

Leusev commented Jul 29, 2020

Uh oh!

Leusev commented Jul 29, 2020

Uh oh!

andreslucena commented Aug 3, 2020

Uh oh!

virgile-dev commented Nov 6, 2020

Uh oh!

carolromero commented Nov 11, 2020

Uh oh!

virgile-dev commented Nov 13, 2020

Uh oh!

Leusev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

virgile-dev commented Nov 18, 2020

Uh oh!

armandfardeau commented Nov 19, 2020

Uh oh!

tramuntanal commented Nov 19, 2020

Uh oh!

Leusev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

armandfardeau commented Jul 10, 2020 •

edited

Loading

virgile-dev commented Jul 22, 2020 •

edited

Loading

Leusev commented Jul 27, 2020 •

edited

Loading

Leusev left a comment •

edited

Loading