chore: move rubocop ruby config to own file#6952
Merged
Conversation
Contributor
Author
|
@decidim/core Could you review this PR? 🙏 Thanks a lot!! |
agustibr
approved these changes
Dec 1, 2020
beagleknight
approved these changes
Dec 1, 2020
ivan-mr
approved these changes
Dec 1, 2020
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…ngs_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…cipatory_processes_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…link * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…ighted_groups * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…s_and_processes_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR moves the
rubocopruby related configuration to a separate file. Like this, therubyconfigurations doesn't inherit therubocop railsconfiguration. This is in so far important, when new gems (e.g. the Bulletin Board gem) don't rely onrails.📌 Related Issues
Testing
Running
rubocopworks the same way as before. But now, we can inherit from these configuration files from anygem.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots