Localize a string in conference speaker#6866
Merged
Leusev merged 3 commits intodecidim:developfrom Nov 27, 2020
Merged
Conversation
Leusev
suggested changes
Nov 16, 2020
| show: | ||
| more_info: more info | ||
| speaking_at: Speaking at | ||
| speaking_at: Speaking at |
Contributor
There was a problem hiding this comment.
Hello @takahashim
why are we adding two entries for 'speaking_at' tag in locales file ? Seems that only show.speaking_at enty would be necessary?
Thanks in advance!
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment!
At first I add conference_speaker.speaking_at into en.yml and it seems OK (and took the screenshot above). But I18N test said conference_speaker.show.speaking_at is missing https://github.com/decidim/decidim/runs/1401753550
I'm not sure why this duplication are needed, but another keyword more_info in app/cells/decidim/conferences/conference_speaker/show.erb is also written in conference_speaker.more_info and conference_speaker.show.more_info, so I guess I should do like that.
Contributor
There was a problem hiding this comment.
Hi again @takahashim !
in first place, thanks for you explanation. 😄
Usually, translations path follow same path as template where they are used. For example, as template path is "decidim/conferences/conference_speaker/show.erb", the "speaking_at" tag would be placed in
decidim:
conferences:
conference_speaker:
show:
speaking_at:
I know this is picky, but you can try removing second one in "decidim.conferences.conference_speaker.speaking_at" and try if it works well? 🙏
Thanks a lot! 😄
Contributor
Author
There was a problem hiding this comment.
OK, I'll try it later 🙆♀️
Contributor
Author
There was a problem hiding this comment.
@Leusev I've tried to do it. However, simply deleting the entry decidim.conferences.conference_speaker.speaking_at caused an I18n::MissingTranslationData error.
After further investigation, it could be successfully displayed by making the following modifications. Should I apply this fix into this PR?
$ git diff
diff --git a/decidim-conferences/app/cells/decidim/conferences/conference_speaker/show.erb b/decidim-conferences/app/cells/decidim/conferences/conference_speaker/show.erb
index c7902382d..1f36da0e7 100644
--- a/decidim-conferences/app/cells/decidim/conferences/conference_speaker/show.erb
+++ b/decidim-conferences/app/cells/decidim/conferences/conference_speaker/show.erb
@@ -70,7 +70,7 @@
<hr class="reset mt-none mb-s">
<div class="row">
<div class="column medium-12">
- <div class="bio-acts"><%= t(".speaking_at") %></div>
+ <div class="bio-acts"><%= t("conferences.conference_speaker.show.speaking_at", scope: "decidim") %></div>
<ul class="list-reset">
<% meetings.each do |meeting| %>
diff --git a/decidim-conferences/config/locales/en.yml b/decidim-conferences/config/locales/en.yml
index b1dfe5474..c0e6a5626 100644
--- a/decidim-conferences/config/locales/en.yml
+++ b/decidim-conferences/config/locales/en.yml
@@ -404,7 +404,6 @@ en:
show:
more_info: more info
speaking_at: Speaking at
- speaking_at: Speaking at
conference_speaker_cell:
personal_url:
personal_website: Personal website
Contributor
There was a problem hiding this comment.
Hi @takahashim
yeah, it's a weird thing what was happening to you.. But for me side, I look well your proposed fix 😄
Yes please, apply it and all will be ok for this PR
Thanks a lot for your time! 👍
Contributor
Author
There was a problem hiding this comment.
Thanks for your commment, I've add a commit.
…ng_at` in `I18n.t()`
Leusev
approved these changes
Nov 27, 2020
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…ngs_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…cipatory_processes_content_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…link * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…ighted_groups * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
entantoencuanto
added a commit
that referenced
this pull request
Dec 2, 2020
…s_and_processes_block * develop: (22 commits) Fix email CTA alignment on Outlook and Windows Mail (#6895) Fix mailer meeting registration invitation using path instead of URL (#6965) Fix the data portability exporter when zip is not in the gemfile (#6969) Convert technical docs to Antora (#6526) New Crowdin updates (#6957) Bugfix - moderated meetings are displayed in the meetings index page (#6927) Add HTML Content Blocks in Process Groups (#6823) Prevent error in view due to optional html not showing (#6942) Improve layout for standalone T&C page (#6944) chore: move rubocop ruby config to own file (#6952) Fix some strings (#6958) Fix newsletter html containing style tag content (#6876) New Crowdin updates (#6945) New Crowdin updates (#6926) Localize a string in conference speaker (#6866) Fix broken dashboard action logs under certain conditions (#6857) Fix traceability logs with invalid record (#6879) Allow user to drag address on proposal map (#6291) New Crowdin updates (#6898) Update release notes documentation (#6809) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix #6733 in English (en.yml).
I tried to use it in ja locale (with same fix in ja.yml), it seems to be valid.
📌 Related Issues
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
EN:
JA:
