Skip to content

Remove the duplicate reference of icons#12083

Merged
andreslucena merged 1 commit intodevelopfrom
chore/remove-duplicated-svg
Nov 29, 2023
Merged

Remove the duplicate reference of icons#12083
andreslucena merged 1 commit intodevelopfrom
chore/remove-duplicated-svg

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Nov 28, 2023

🎩 What? Why?

This PR attempts to remove any deprecation message that has been added while implementing #11982
This will remove from logs the following messages:

DEPRECATION WARNING: link already registered. {"name"=>"link", "icon"=>"link", "description"=>"", "category"=>"system", "engine"=>:core} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-core/lib/decidim/core/engine.rb:191)
DEPRECATION WARNING: Decidim::ParticipatoryProcess already registered. {"name"=>"Decidim::ParticipatoryProcess", "icon"=>"treasure-map-line", "description"=>"Participatory Process", "category"=>"activity", "engine"=>:participatory_process} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-participatory_processes/lib/decidim/participatory_processes/engine.rb:52)
DEPRECATION WARNING: drag-move-2-line already registered. {"name"=>"drag-move-2-line", "icon"=>"drag-move-2-line", "description"=>"", "category"=>"system", "engine"=>:forms} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-participatory_processes/lib/decidim/participatory_processes/engine.rb:55)
DEPRECATION WARNING: login-circle-line already registered. {"name"=>"login-circle-line", "icon"=>"login-circle-line", "description"=>"", "category"=>"system", "engine"=>:verifications} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-meetings/lib/decidim/meetings/engine.rb:57)
DEPRECATION WARNING: drag-move-2-fill already registered. {"name"=>"drag-move-2-fill", "icon"=>"drag-move-2-fill", "description"=>"", "category"=>"system", "engine"=>:forms} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-meetings/lib/decidim/meetings/engine.rb:61)
DEPRECATION WARNING: list-check already registered. {"name"=>"list-check", "icon"=>"list-check", "description"=>"", "category"=>"system", "engine"=>:budgets} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-blogs/lib/decidim/blogs/engine.rb:26)
DEPRECATION WARNING: list-check already registered. {"name"=>"list-check", "icon"=>"list-check", "description"=>"", "category"=>"system", "engine"=>:blogs} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-elections/lib/decidim/elections/engine.rb:33)
DEPRECATION WARNING: add-fill already registered. {"name"=>"add-fill", "icon"=>"add-fill", "description"=>"", "category"=>"system", "engine"=>:debates} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-initiatives/lib/decidim/initiatives/engine.rb:92)
DEPRECATION WARNING: clipboard-line already registered. {"name"=>"clipboard-line", "icon"=>"clipboard-line", "description"=>"", "category"=>"system", "engine"=>:templates} (called from block in <class:Engine> at /home/alecslupu/Sites/decidim/redesign/decidim-initiatives/lib/decidim/initiatives/engine.rb:95)

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Make sure that the pipelines are green, and there are no deprecation messages, with regard to the icons.

📷 Screenshots

Please add screenshots of the changes you are proposing
image
♥️ Thank you!

@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Nov 28, 2023
@alecslupu alecslupu marked this pull request as ready for review November 28, 2023 21:32
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Nov 28, 2023

Failing spec in core should be fixed by #12084

@alecslupu alecslupu requested a review from a team November 28, 2023 21:35
andreslucena
andreslucena approved these changes Nov 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit 0a69f3a into develop Nov 29, 2023
@andreslucena andreslucena deleted the chore/remove-duplicated-svg branch November 29, 2023 06:42
entantoencuanto added a commit that referenced this pull request Nov 29, 2023
@entantoencuanto
Merge branch 'fix/control-comments-replies-polymorphism' into feature…
09d84db 
…/redesign-staging

* fix/control-comments-replies-polymorphism:
  Add a polymorphic option to restrict acts_as_tree lookup
  Add tests to check the 'Hide replies' message error
  Fix pipeline after translations were updated (#12084)
  Remove the duplicate reference of icons (#12083)
  Fix modal forms for editor (#12077)
  New Crowdin updates (#12003)
  Display only once resource type in search (#12041)
  Redesign: fix responsiveness on nav-bar admin (#12045)
  Apply flash styles to Announcements (part 2) (#12039)
  Remove legacy design support from WYSIWYG editor (TipTap) (#12015)
  Extract methods from meetings seeds (#12053)
  Show message when there are no content in the page (#12056)
  Show message when there are no sortitions (#12057)
  Fix icons on flash alerts (#12069)
  Update numbering in RELEASE_NOTES.md (#12066)
  Add prerequirements to the manual installation tutorial (#12068)
  Differentiate non-clickable elements in admin menu (#12000)
  Remove official logo header image (#12064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@andreslucena andreslucena

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecslupu @andreslucena