Remove legacy design support from WYSIWYG editor (TipTap)#12015
Merged
Remove legacy design support from WYSIWYG editor (TipTap)#12015
Conversation
8aff6aa to
19dd0e1
Compare
entantoencuanto
added a commit
that referenced
this pull request
Nov 29, 2023
…/redesign-staging * fix/control-comments-replies-polymorphism: Add a polymorphic option to restrict acts_as_tree lookup Add tests to check the 'Hide replies' message error Fix pipeline after translations were updated (#12084) Remove the duplicate reference of icons (#12083) Fix modal forms for editor (#12077) New Crowdin updates (#12003) Display only once resource type in search (#12041) Redesign: fix responsiveness on nav-bar admin (#12045) Apply flash styles to Announcements (part 2) (#12039) Remove legacy design support from WYSIWYG editor (TipTap) (#12015) Extract methods from meetings seeds (#12053) Show message when there are no content in the page (#12056) Show message when there are no sortitions (#12057) Fix icons on flash alerts (#12069) Update numbering in RELEASE_NOTES.md (#12066) Add prerequirements to the manual installation tutorial (#12068) Differentiate non-clickable elements in admin menu (#12000) Remove official logo header image (#12064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
On #10196, we've introduced the TipTap editor. We had to support the two designs (the redesign and the legacy) as the frontend had the new design but the admin not (yet). Now that the admin also has the redesign, we can drop this support.
As this is dead code, we should have the same behaviour and all the specs should pass.
📌 Related Issues
Testing
Use the WYSIWYG editor and it should work the same
All the specs should pass