Skip to content

Redesign: fix responsiveness on nav-bar admin#12045

Merged
alecslupu merged 4 commits intodecidim:developfrom
greenwoodt:fix/screen-overflow-navbar
Nov 25, 2023
Merged

Redesign: fix responsiveness on nav-bar admin#12045
alecslupu merged 4 commits intodecidim:developfrom
greenwoodt:fix/screen-overflow-navbar

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Nov 21, 2023

🎩 What? Why?

This fixes an issue with the nav-bar that allows users on mobile on smaller screens to navigate and use features available there with no responsive issues.

📌 Related Issues

Testing

  1. Login as a admin and head over to edit (admin panel)
  2. Find a module like Processes and access one
  3. Head over to a component like Accountability
  4. Make your screen smaller like mobile dimensions
  5. See the nav bar options be more accessible

📷 Screenshots

Screenshot 2023-11-21 at 12 03 01

♥️ Thank you!

@greenwoodt greenwoodt added module: core module: admin type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract labels Nov 21, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2023
View reviewed changes
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Nov 21, 2023

The Breadcrumb looks great! I would handle the menu in this PR as well...
This is what we have:
image

This is what i would expect:
image
image

The .sidebar-menu to have a padding of 0.5 rem when on mobile. Maybe @andreslucena has other opinion ?

@greenwoodt
Copy link
Copy Markdown
Member Author

greenwoodt commented Nov 21, 2023

The Breadcrumb looks great! I would handle the menu in this PR as well... This is what we have: image

This is what i would expect: image image

The .sidebar-menu to have a padding of 0.5 rem when on mobile. Maybe @andreslucena has other opinion ?

Thanks @alecslupu, nice to have a more responsive view on mobile.

Are you referring to the margin on the menu?

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Nov 22, 2023

Are you referring to the margin on the menu?

Yes, but that is a padding. Check my previous comment.

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 22, 2023

Maybe @andreslucena has other opinion ?

No, that's great!

@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Nov 22, 2023
@andreslucena andreslucena changed the title Redesign: Responsiveness on nav-bar admin Redesign: fix responsiveness on nav-bar admin Nov 22, 2023
@greenwoodt greenwoodt requested a review from alecslupu November 23, 2023 09:02
@greenwoodt
Copy link
Copy Markdown
Member Author

greenwoodt commented Nov 23, 2023

I have updated the padding in the .sidebar-menuto 1rem.

This now ready for a review whenever you're ready @alecslupu.

alecslupu
alecslupu approved these changes Nov 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It could be further improved , but now is much better than before.

image

@alecslupu alecslupu merged commit 739107b into decidim:develop Nov 25, 2023
entantoencuanto added a commit that referenced this pull request Nov 29, 2023
@entantoencuanto
Merge branch 'fix/control-comments-replies-polymorphism' into feature…
09d84db 
…/redesign-staging

* fix/control-comments-replies-polymorphism:
  Add a polymorphic option to restrict acts_as_tree lookup
  Add tests to check the 'Hide replies' message error
  Fix pipeline after translations were updated (#12084)
  Remove the duplicate reference of icons (#12083)
  Fix modal forms for editor (#12077)
  New Crowdin updates (#12003)
  Display only once resource type in search (#12041)
  Redesign: fix responsiveness on nav-bar admin (#12045)
  Apply flash styles to Announcements (part 2) (#12039)
  Remove legacy design support from WYSIWYG editor (TipTap) (#12015)
  Extract methods from meetings seeds (#12053)
  Show message when there are no content in the page (#12056)
  Show message when there are no sortitions (#12057)
  Fix icons on flash alerts (#12069)
  Update numbering in RELEASE_NOTES.md (#12066)
  Add prerequirements to the manual installation tutorial (#12068)
  Differentiate non-clickable elements in admin menu (#12000)
  Remove official logo header image (#12064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@andreslucena andreslucena Awaiting requested review from andreslucena

+1 more reviewer

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alecslupu alecslupu

Labels

module: admin module: core no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breadcrumb responsiveness on nav in admin

3 participants

@greenwoodt @alecslupu @andreslucena