Skip to content

Fix icons on flash alerts#12069

Merged
alecslupu merged 2 commits intodevelopfrom
fix/announcement-design-part2
Nov 25, 2023
Merged

Fix icons on flash alerts#12069
alecslupu merged 2 commits intodevelopfrom
fix/announcement-design-part2

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

After merging #12067, I realized that I messed up the CSS for the flash alerts, that use the same CSS than announcements.

This PR fixes that.

📌 Related Issues

Testing

  1. Log in and see a flash alert

📷 Screenshots

Before

Flash alert broken

After

Flash alert fixed

♥️ Thank you!

@andreslucena andreslucena added type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract no-backport Pull Requests that should not be backported labels Nov 24, 2023
@andreslucena andreslucena changed the title Fix layout disposition when there are icons in flash Fix icons on flash alerts Nov 24, 2023
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

image
image

@alecslupu alecslupu merged commit fe970cd into develop Nov 25, 2023
@alecslupu alecslupu deleted the fix/announcement-design-part2 branch November 25, 2023 08:15
entantoencuanto added a commit that referenced this pull request Nov 29, 2023
…/redesign-staging

* fix/control-comments-replies-polymorphism:
  Add a polymorphic option to restrict acts_as_tree lookup
  Add tests to check the 'Hide replies' message error
  Fix pipeline after translations were updated (#12084)
  Remove the duplicate reference of icons (#12083)
  Fix modal forms for editor (#12077)
  New Crowdin updates (#12003)
  Display only once resource type in search (#12041)
  Redesign: fix responsiveness on nav-bar admin (#12045)
  Apply flash styles to Announcements (part 2) (#12039)
  Remove legacy design support from WYSIWYG editor (TipTap) (#12015)
  Extract methods from meetings seeds (#12053)
  Show message when there are no content in the page (#12056)
  Show message when there are no sortitions (#12057)
  Fix icons on flash alerts (#12069)
  Update numbering in RELEASE_NOTES.md (#12066)
  Add prerequirements to the manual installation tutorial (#12068)
  Differentiate non-clickable elements in admin menu (#12000)
  Remove official logo header image (#12064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants