Conversation
|
@andreslucena , @Crashillo have a look on this PR, if you agree with the approach, i will go and extract all the svg icons in their own modules ( some modules may have custom icons like the ones from; |
So, this would also fix #11137, right? |
andreslucena
left a comment
There was a problem hiding this comment.
This is just what I had in mind 😄
|
I will mention @entantoencuanto to discuss about the approach, since the Ruby/Rails is not my strong point 😅 |
I think it would as, it would enable us to call it from whatever place we would like. |
|
Hi, I think that this approach is a great improvement! My only doubt is if you are considering to provide a method to be used by the design application to get all the icons and group them by category. Currently this is done accessing directly to the icons hash in the helper and grouping. But the IconRegistry class does not provide a public method returning this hash or a structure grouped by category |
This will be added ... I just wanted to validate the approach on the matter. |
|
I've updated the issues that'll be closed when we merge this one 😄 |
andreslucena
left a comment
There was a problem hiding this comment.
All in all I'm really happy with how this looks like. Now we have a documentation system with all the Decidim icons 🚀
For now I'll ignore two things:
- The categories: we should probably rethink them to something that makes more sense. I'll leave that out of the scope of the current PR, only asking for one small change, of merging the "Action" and "Actions" categories. Most likely is that I'll review the categories with @decidim/product in the future to propose a reorganization
- The descriptions: as of now it's missing in lots of icons, it's out of the scope of the current PR so we don't drag this merge.
Apart from that I think I found a couple minor things, can you check them out please?
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* develop: (51 commits) Fix a11y violations and title layout on announcements (#12067) Fix randomness on nickname and emails for seeded users (#12058) Fix render partial deprecation warning on proposals (#12035) Redesign: proposal counter total number avaliable (#12014) Fix disabling access to space private users when the space is public (#12031) Redesign: admin screen overflow on smaller screens (#11956) Make the breadcrumb consistent in the components import pages (#12024) Fix develop branch (#12051) Create the IconRegistry (#11982) Fix process groups component content blocks (#11872) Remove the asemblies settings page (#11873) Fix n+1 query on assemblies permissions (#12040) Remove unused scope filter from search controller and command (#12038) Fix issues in "Verify your identity" (#12030) Fix flash of dropdowns in buttons from the title bar and "Manage" button (#12011) Add CI workflow configuration for decidim-design (#12022) Extract methods from participatory processes seeds (#12032) Show message when there are no debates (#12037) Show error message when there are no budgets nor projects in budgets (#12034) Fix faker requirement in production environment 2 (#12033) ...
🎩 What? Why?
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots