Skip to content

Fix process groups component content blocks#11872

Merged
andreslucena merged 3 commits intodevelopfrom
fix/process-groups-component-content-blocks
Nov 21, 2023
Merged

Fix process groups component content blocks#11872
andreslucena merged 3 commits intodevelopfrom
fix/process-groups-component-content-blocks

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Oct 30, 2023

🎩 What? Why?

This PR:

  • Fixes a wrong behavior of participatory processes groups landing page content blocks associated to components because the blocks select resources from all components of the same type instead of selecting only resources from components defined on the processes included in the group.
  • Adds some tests

📌 Related Issues

Link your PR to an issue

Testing

Define a participatory process group and include in the landing page blocks for meetings, results or proposals,
Publish meetings, results or proposals in components defined and published on participatory spaces not included in the group. Those resources should not appear in the group landing page

github-actions[bot]
github-actions bot requested changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@entantoencuanto entantoencuanto added type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract labels Oct 30, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 30, 2023
View reviewed changes
@entantoencuanto entantoencuanto marked this pull request as ready for review October 30, 2023 19:57
@andreslucena andreslucena self-assigned this Oct 31, 2023
@andreslucena andreslucena changed the title Redesign: Fix process groups component content blocks Redesign: fix process groups component content blocks Oct 31, 2023
andreslucena
andreslucena requested changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked it out locally and it works well. I saw that you have also taken care of the Results through a spec so that's a 💯

I just have a little change on making a few methods private and we're good to go

@entantoencuanto @andreslucena
Update decidim-core/lib/decidim/content_blocks/has_related_components.rb
c755909 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
andreslucena approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena changed the title Redesign: fix process groups component content blocks Fix process groups component content blocks contents from other spaces Nov 14, 2023
@andreslucena andreslucena changed the title Fix process groups component content blocks contents from other spaces Fix process groups component content blocks from other spaces Nov 14, 2023
@andreslucena andreslucena changed the title Fix process groups component content blocks from other spaces Fix process groups component content blocks Nov 14, 2023
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 14, 2023

@entantoencuanto I was checking out the history of has_related_components.rb and it seems like it was introduced in the Redesign. Is that right? I'm mentioning to know if I should add the no-backport label or not.

Do you know if this bug should happen in v0.27?

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 20, 2023

@entantoencuanto have you seen my last question?

@entantoencuanto
Copy link
Copy Markdown
Contributor Author

entantoencuanto commented Nov 20, 2023

I'll take a look today and reply

@entantoencuanto entantoencuanto added the no-backport Pull Requests that should not be backported label Nov 20, 2023
@entantoencuanto
Copy link
Copy Markdown
Contributor Author

entantoencuanto commented Nov 20, 2023 •
edited
Loading

I've reviewed the previous code and you are right, the issue solved in this PR appeared with redesign (the previous blocks ensured to query only for resources from the components belonging to the processes of the group)

I have already added the no-backport label after checking this

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 21, 2023

@entantoencuanto awesome, thanks for the answer

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 21, 2023

Only one failing action, codecov as usual. I'm merging this

@andreslucena andreslucena merged commit 4ac2f4f into develop Nov 21, 2023
@andreslucena andreslucena deleted the fix/process-groups-component-content-blocks branch November 21, 2023 09:12
entantoencuanto added a commit that referenced this pull request Nov 27, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-staging
a7d94fb 
* develop: (51 commits)
  Fix a11y violations and title layout on announcements (#12067)
  Fix randomness on nickname and emails for seeded users (#12058)
  Fix render partial deprecation warning on proposals (#12035)
  Redesign: proposal counter total number avaliable (#12014)
  Fix disabling access to space private users when the space is public (#12031)
  Redesign: admin screen overflow on smaller screens (#11956)
  Make the breadcrumb consistent in the components import pages (#12024)
  Fix develop branch (#12051)
  Create the IconRegistry (#11982)
  Fix process groups component content blocks (#11872)
  Remove the asemblies settings page (#11873)
  Fix n+1 query on assemblies permissions (#12040)
  Remove unused scope filter from search controller and command (#12038)
  Fix issues in "Verify your identity" (#12030)
  Fix flash of dropdowns in buttons from the title bar and "Manage" button (#12011)
  Add CI workflow configuration for decidim-design (#12022)
  Extract methods from participatory processes seeds (#12032)
  Show message when there are no debates (#12037)
  Show error message when there are no budgets nor projects in budgets (#12034)
  Fix faker requirement in production environment 2 (#12033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@andreslucena andreslucena

Labels

no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

2 participants

@entantoencuanto @andreslucena