Fix disabling access to space private users when the space is public#12031
Merged
andreslucena merged 7 commits intodevelopfrom Nov 22, 2023
Merged
Fix disabling access to space private users when the space is public#12031andreslucena merged 7 commits intodevelopfrom
andreslucena merged 7 commits intodevelopfrom
Conversation
andreslucena
requested changes
Nov 20, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
LGTM functionality wise and code-wise, but there are some relevant failing specs. Can you check them out please?
andreslucena
requested changes
Nov 20, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I think we should change the permission to prevent accessing directly from the URL (sorry that I didn't realized about this before!)
andreslucena
previously requested changes
Nov 21, 2023
decidim-assemblies/app/permissions/decidim/assemblies/permissions.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/permissions/decidim/assemblies/permissions.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/permissions/decidim/assemblies/permissions.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/spec/permissions/decidim/assemblies/permissions_spec.rb
Show resolved
Hide resolved
entantoencuanto
added a commit
that referenced
this pull request
Nov 27, 2023
* develop: (51 commits) Fix a11y violations and title layout on announcements (#12067) Fix randomness on nickname and emails for seeded users (#12058) Fix render partial deprecation warning on proposals (#12035) Redesign: proposal counter total number avaliable (#12014) Fix disabling access to space private users when the space is public (#12031) Redesign: admin screen overflow on smaller screens (#11956) Make the breadcrumb consistent in the components import pages (#12024) Fix develop branch (#12051) Create the IconRegistry (#11982) Fix process groups component content blocks (#11872) Remove the asemblies settings page (#11873) Fix n+1 query on assemblies permissions (#12040) Remove unused scope filter from search controller and command (#12038) Fix issues in "Verify your identity" (#12030) Fix flash of dropdowns in buttons from the title bar and "Manage" button (#12011) Add CI workflow configuration for decidim-design (#12022) Extract methods from participatory processes seeds (#12032) Show message when there are no debates (#12037) Show error message when there are no budgets nor projects in budgets (#12034) Fix faker requirement in production environment 2 (#12033) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes the private user menu entry issue described in #9854
📌 Related Issues
Link your PR to an issue
Testing