Skip to content

Show message when there are no debates#12037

Merged
alecslupu merged 1 commit intodevelopfrom
fix/debates-no-results
Nov 20, 2023
Merged

Show message when there are no debates#12037
alecslupu merged 1 commit intodevelopfrom
fix/debates-no-results

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

When there are no debates in debates, we don't show any message, just a blank page.

This PR changes it to show a message.

I've found about this error while reviewing #11480.

📌 Related Issues

Testing

  1. Create a new process
  2. Create a debates component
  3. Click in the "Preview" icon in the admin's component page
  4. See the page

📷 Screenshots

Screenshot of the no debates page in debates module

♥️ Thank you!

@andreslucena andreslucena added module: debates type: fix PRs that implement a fix for a bug labels Nov 20, 2023
@andreslucena andreslucena changed the title Show message when there are no debates in debates Show message when there are no debates Nov 20, 2023
@andreslucena andreslucena marked this pull request as ready for review November 20, 2023 14:31
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 56b4fb1 into develop Nov 20, 2023
@alecslupu alecslupu deleted the fix/debates-no-results branch November 20, 2023 19:28
entantoencuanto added a commit that referenced this pull request Nov 27, 2023
* develop: (51 commits)
  Fix a11y violations and title layout on announcements (#12067)
  Fix randomness on nickname and emails for seeded users (#12058)
  Fix render partial deprecation warning on proposals (#12035)
  Redesign: proposal counter total number avaliable (#12014)
  Fix disabling access to space private users when the space is public (#12031)
  Redesign: admin screen overflow on smaller screens (#11956)
  Make the breadcrumb consistent in the components import pages (#12024)
  Fix develop branch (#12051)
  Create the IconRegistry (#11982)
  Fix process groups component content blocks (#11872)
  Remove the asemblies settings page (#11873)
  Fix n+1 query on assemblies permissions (#12040)
  Remove unused scope filter from search controller and command (#12038)
  Fix issues in "Verify your identity" (#12030)
  Fix flash of dropdowns in buttons from the title bar and "Manage" button (#12011)
  Add CI workflow configuration for decidim-design (#12022)
  Extract methods from participatory processes seeds (#12032)
  Show message when there are no debates (#12037)
  Show error message when there are no budgets nor projects in budgets (#12034)
  Fix faker requirement in production environment 2 (#12033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: debates type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants