Refactor dropdown scroll to menu#11710
Conversation
Crashillo
left a comment
There was a problem hiding this comment.
Yeea! much better, simpler, cleaner... :) ...............This is the way
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…own-scroll-to-menu
|
@andreslucena Since you also reviewed this PR i am waiting your input as well before merging. |
andreslucena
left a comment
There was a problem hiding this comment.
It works, but I'm not happy with the current approach on this file regarding the number of characters by each line. In this particular line we're on 247 characters.
I'm not saying that we need to go the oldschool way of 80 characters, but it really makes difficult to understand whats going on here.
As I see that there are others places in this file where we're doing the same, I'll merge this one and make a refactor of this file with what I have in mind, as that'll be faster.
Thanks for the PR with the fix and taking care of this issue guys!
* feature/renaming-redesign: Use default current participatory space scope as root on scopes_select_tag called from bulk actions restore the imports thing (compilation fails for initiatives) change testing color: dequelabs/axe-core#3513 (comment) Fix admin redesign module (#11648) Apply flash styles to Announcements (#11708) Refactor oneliners of redesigned_a11y.js (#11713) Redesign: fix votings admin module issues (#11704) Add meta robots noindex to search and profile (#10120) Refactor dropdown scroll to menu (#11710) Remove unused partial Remove REDESIGN_PENDING obsolete comand Redesign: fix assembly members sidebar menu (#11699) Redesign: fix conferences admin module issues (#11703) Redesign: fix assemblies admin module issues (#11702)
🎩 What? Why?
As @Crashillo commented here after the PR was merged, I have opened a new one following the tips he left.
📌 Related Issues
Testing
From a mobile phone:
📷 Screenshots
Screen.Recording.2023-09-29.at.14.01.51.mov