Skip to content

Fix admin redesign module#11648

Merged
andreslucena merged 9 commits intodevelopfrom
fix/admin-redesign
Oct 5, 2023
Merged

Fix admin redesign module#11648
andreslucena merged 9 commits intodevelopfrom
fix/admin-redesign

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Sep 22, 2023 •
edited
Loading

🎩 What? Why?

This PR fixes the main admin module issues revealed by #11596

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract labels Sep 23, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Sep 23, 2023
@alecslupu alecslupu mentioned this pull request Sep 23, 2023
Merged
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Sep 27, 2023

Is this one ready to be reviewed @alecslupu?

@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Sep 27, 2023

Is this one ready to be reviewed @alecslupu?

As i have said in the maintainer's meeting, i would keep this as draft for the time being, to serve as template for @greenwoodt .

@alecslupu alecslupu mentioned this pull request Sep 29, 2023
Merged
25 tasks
@alecslupu alecslupu marked this pull request as ready for review October 4, 2023 10:51
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Oct 4, 2023

@andreslucena, there a few elements (in 2 files) that i could not find. I could either fix them in the scope of this PR, or we could address them in a separate PR ( i would not keep this blocked any longer)

@alecslupu alecslupu requested a review from a team October 4, 2023 10:53
andreslucena
andreslucena requested changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question for starters... Also, can you please merge with develop? Not having the sidebar and sections changes from the past few days make more difficult to compare this with nightly. Thanks

Comment thread decidim-admin/app/views/decidim/admin/components/edit.html.erb
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Oct 4, 2023

I have one question for starters... Also, can you please merge with develop? Not having the sidebar and sections changes from the past few days make more difficult to compare this with nightly. Thanks

Sync is done

@alecslupu alecslupu requested a review from andreslucena October 4, 2023 12:33
andreslucena
andreslucena requested changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of missing stickys (IMO), can you check them?

Comment thread decidim-admin/app/views/decidim/admin/moderations/reports/index.html.erb Outdated
Comment thread decidim-admin/app/views/decidim/admin/moderations/reports/show.html.erb Outdated
@alecslupu alecslupu requested a review from andreslucena October 4, 2023 15:58
andreslucena
andreslucena approved these changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit d15dcd6 into develop Oct 5, 2023
@andreslucena andreslucena deleted the fix/admin-redesign branch October 5, 2023 05:02
entantoencuanto added a commit that referenced this pull request Oct 5, 2023
@entantoencuanto
Merge branch 'develop' into feature/renaming-redesign
63d588c 
* develop:
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
entantoencuanto added a commit that referenced this pull request Oct 5, 2023
@entantoencuanto
Merge branch 'develop' into feature/renaming-redesign
69ec95e 
* develop:
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
entantoencuanto added a commit that referenced this pull request Oct 6, 2023
@entantoencuanto
Merge branch 'feature/renaming-redesign' into feature/redesign-staging
ab520b6 
* feature/renaming-redesign:
  Use default current participatory space scope as root on scopes_select_tag called from bulk actions
  restore the imports thing (compilation fails for initiatives)
  change testing color: dequelabs/axe-core#3513 (comment)
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
  Refactor dropdown scroll to menu (#11710)
  Remove unused partial
  Remove REDESIGN_PENDING obsolete comand
  Redesign: fix assembly members sidebar menu (#11699)
  Redesign: fix conferences admin module issues (#11703)
  Redesign: fix assemblies admin module issues (#11702)
andreslucena pushed a commit that referenced this pull request Oct 16, 2023
@alecslupu @andreslucena
Fix admin redesign module (#11648)
ba0b219 
* Fix admin redesign module

* More admin customizations

* Lint erb

* Remove components sidebar

* Apply review recommendations
@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

module: admin no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

Admin module Issues

2 participants

@alecslupu @andreslucena