Skip to content

Redesign: fix votings admin module issues#11704

Merged
andreslucena merged 2 commits intodevelopfrom
fix/elections-admin
Oct 4, 2023
Merged

Redesign: fix votings admin module issues#11704
andreslucena merged 2 commits intodevelopfrom
fix/elections-admin

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR fixes the assemblies admin module issues revealed by #11608

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added module: elections project: redesign Barcelona City Council contract labels Oct 2, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Oct 2, 2023
@alecslupu alecslupu force-pushed the fix/elections-admin branch from a76f132 to ee1b03a Compare October 2, 2023 19:41
@alecslupu alecslupu marked this pull request as ready for review October 2, 2023 20:48
@andreslucena andreslucena changed the title Redesign: Fix votings admin module issues Redesign: fix votings admin module issues Oct 3, 2023
@alecslupu alecslupu requested a review from a team October 4, 2023 08:34
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an indentation change and a couple of doubts about the change of specs. Can you check it out please?

Comment thread decidim-elections/app/views/decidim/votings/admin/polling_stations/_form.html.erb Outdated
…ions/_form.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu requested a review from andreslucena October 4, 2023 12:05
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit 7e24345 into develop Oct 4, 2023
@andreslucena andreslucena deleted the fix/elections-admin branch October 4, 2023 13:04
entantoencuanto added a commit that referenced this pull request Oct 5, 2023
* develop:
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
entantoencuanto added a commit that referenced this pull request Oct 5, 2023
* develop:
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
entantoencuanto added a commit that referenced this pull request Oct 6, 2023
* feature/renaming-redesign:
  Use default current participatory space scope as root on scopes_select_tag called from bulk actions
  restore the imports thing (compilation fails for initiatives)
  change testing color: dequelabs/axe-core#3513 (comment)
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
  Refactor dropdown scroll to menu (#11710)
  Remove unused partial
  Remove REDESIGN_PENDING obsolete comand
  Redesign: fix assembly members sidebar menu (#11699)
  Redesign: fix conferences admin module issues (#11703)
  Redesign: fix assemblies admin module issues (#11702)
andreslucena added a commit that referenced this pull request Oct 16, 2023
* Redesign: Fix votings admin module issues

* Update decidim-elections/app/views/decidim/votings/admin/polling_stations/_form.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena added type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Admin elections Issues

2 participants